Add a block render function outside layouts

[bennybobw]

Add a block render function outside layouts

There are contrib modules that render blocks programmatically, e.g. blockreference and insert_block, among others. Currently, LayoutRendererStandard owns the renderBlock method, meaning that third-party modules have to implement their own version of a block render function. For instance blockreference implements _blockreference_get_renderable_array and a variety of theme functions to get this working.

Proposed solution

Pull the code that renders blocks out of LayoutRendererStandard and into the block module.

Alternatives that have been considered

Someone suggested implementing a Render class independendent of LayoutRenderer, but the block module approach seems more straightforward to me.

[bennybobw]

This is just an initial patch, I don't know how to write tests for this stuff, so could use some guidance and also I'm sure there are things that will need tweaking. I looked at _blockreference_get_renderable_array as a reference along with the standard layout blockRender.

[herbdool]

@bennybobw can you make this a PR? Right now it's a commit. The "Fixes ..." part goes into the PR body. The message of the commit can be whatever you would normally but in a commit. Go to backdrop/backdrop@1.x...bennybobw:backdrop:6893-block-render and create the PR. Put the "Fixes ..." text there in the body (not the PR title).

[avpaderno]

The Simpletest tests fail.

[bennybobw]

@avpaderno

I tried a new commit but I'm still getting a hang of the workflow. Do the automated tests run with tugboat or do they have to be triggered manually?

I tried running all the tests on one of my local installs. It's a vanilla install but I'm getting a bunch of fails unrelated to the work I did. Is that normal or is there something wrong with my setup?

[laryn]

@bennybobw No, that's not normal. I've approved the workflows here. And the workflows should run here automatically if you are on the "Documentation and Organization" team, I believe -- I see that there was an invitation out to you but it expired before you accepted it. I just retried that invitation to you.

[bennybobw]

@laryn

Got it thank you, I've accepted this time. I'm looking at the tests that just failed and I'm having trouble understanding it. Here's the code for the test that it says is failing:

https://github.com/backdrop/backdrop/actions/runs/15075195132/job/42383032158?pr=5076

---- Configuration: Configuration sync (ConfigurationSyncTest) ----
Status Group Filename Line Function

Fail Other config.test 645 testSync()
"Post Test post has been created." found

in core/modules/config/tests/config.test

    $this->backdropPost('node/add/post', array(
      'title' => 'Test post',
      'field_config_test[und][0][value]' => 'Test value in the new field',
    ), t('Save'));

    $this->assertText('Post Test post has been created.');

As far as I can tell that has nothing to do with my block change. And when I look on my local instance, I don't see the field_config_test field that it says should be there, unless the test automatically cleans those up when it fails? I wouldn't expect that.

[laryn]

@bennybobw I checked out your PR and spun up a local. When I create a post, I don't see the success message:

If I checkout 1.x and create a post, here's what I see: