-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UX] Rename instances of "database update(s)" to "system update(s)" #1986
Comments
I can try a PR if we agree on the name. |
This was recently brought up by @laryn in Zulip, during the preparation of the 1.22.0 release: https://backdrop.zulipchat.com/#narrow/stream/218635-Backdrop/topic/Release.20Day/near/282444669
...
|
I'm supporting this! And if it were only that I don't have to 🙄 on every Backdrop update with CMI-only changes. I'm not sure if I can help much with wording, though. ("System updates" seems a little weird to me.) |
Here's an initial PR for this: backdrop/backdrop#4203 I have changed things to "system updates" for now, but happy to change it to anything better we may come up with. I have left 3 instances of "database update" in |
Thanks for having a look @kiamlaluno 🙏🏼 ...any others to chime in? ...any thoughts re using "system updates" for what we should be calling these things? ...any other suggestions? PS: I've rebased and pushed changes, which triggered the re-creation of the PR sandbox if anyone wants to poke around the UI. |
I can't think of anything better than "system updates" at the moment (and "system updates" is better than "database updates"). |
The issue with System Updates is that we already have a page called System Updates that takes care of downloading core and contrib when there are updates. This may create confusion. So, after doing "System Updates" (downloaded the updates), we will be prompt to "Run system updates" again? The end user could care less if the "Database Updates" are not really "Database Updates" - it's all part of the process. While as a developer I understand the change of language, I don't see how it may be helpful to the site builder. |
Good point about that existing page! I'd still like to try to clarify the name if possible. Would "internal updates" work? Or would "database/config updates" be too bulky? |
I agree that System updates might be confusing. Even if it is a bit lengthy, I'd prefer something like "Database / config updates", depending on the context, e.g.:
|
Hey, this could just be the solution. 👍 I'd vote for "Update tasks". |
I like that too. |
Indeed, "Update tasks" sounds good!
Maybe better "your database and your configuration files"? (IIRC, database updates can also be related to configuration. If that's true, config files would be a more clear differentiation.) |
I would rather call them updates, if system updates can create confusion with the existing page. |
"Database/config updates" nicely and concisely describes what's happening. True that many admins won't know or care about the distinction, but for some it might even be a bit educational. |
I'm fine with that too. |
Right, I also think that the following makes sense:
|
I'm fine with any suggestion here. I have a slight preference for "Database/config updates" |
I think using the same terminology for these things makes a lot of sense, actually. Using the installer module we install the module (download the code) before we install the module (turn it on and run any datayabse+config changes). Both steps are required to install.
If we do decide to go with this alternative, I think it needs to be full and complete words, like
These things are step 1 and step 2 of the same process. Both steps are required to update. If "Database/config updates" won't ever be done without also doing "System updates" why don't we just call them by the same name? If we're going to label step 2 of "System updates" specifically, It might be better to also re-label step 1, perhaps as follows:
I've done a code review and marked this issue RTBC (it currently uses "System updates"), but if we need more time to discuss terminology, we should remove either that or "works for me" so it doesn't get merged :) |
I'm moving this back to review as it seems like several people expressed concerns about using the term "System Updates" (which is what backdrop/backdrop#4203 uses). I think "System Updates" is better than "Database Updates", but the above feedback is valid. I'm leaning towards merging this as-is. If someone else agrees that this is fine as-is; please move this back to RTBC then I'll merge it. |
With #5630 landing in 1.28.1, we've now changed "database updates" to "site updates"! 🎉 ...I'll double-check if there's anything useful in the comments above. or in the PR that we need to consider, and will then close this. |
I've filed #6644 as a follow-up. Closing. |
We do CMI config file updates too, which are not db updates. Proper would be "Database and config updates", but too verbose. I think "system" encompasses both db and config, so I think that we should go with that unless there are better suggestions.
The text was updated successfully, but these errors were encountered: