Add phpcs checks to PRs for backdrop/backdrop. #460
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks correct, but need to be tested |
41 tasks
|
@quicksketch any harm in merging this so we can see if it fires the phpcs-diff-only check? |
|
Sure, let's give it a go... I'll merge and then deploy onto backdropcms.org. |
|
We've been seeing very long run times on tests, @Gormartsen thinks this is probably related. As the PHPCS check didn't work quite right even when it did run, I've reverted this PR and redeployed to see if that resolves the problem with extremely long run times. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.