You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In my limited testing (boolean checkbox changing visibility and required status of link field), this fixed as long as I worked with the value of boolean field rather than the status of checked.
@yorkshire-pudding
I haven't had a chance to do a full review but it looks like you are adding back some code that had been removed (e.g. Features-related) and removing some code that had been added (a module_includes that I'm trying to remember why it was needed). Can you make sure the PR only changes things directly related to the patch for this issue? If those other things are also issues please open a separate issue for them.
@laryn
I don't understand how that could have happened. I cloned your repo, downloaded the patch from Drupal and then manually applied all the individual patch items by copying and pasting. I don't understand git enough to know I could possibly have introduced anything that wasn't in the patch as that is all I did.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14
Apply patch from D7 issue mentioned comment #209
In my limited testing (boolean checkbox changing visibility and required status of link field), this fixed as long as I worked with the value of boolean field rather than the status of checked.
I suggest this may be good enough.