Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add description key name to prevent e-notice #244

Merged
merged 1 commit into from
Jul 12, 2021

Conversation

eileenmcnaughton
Copy link
Contributor

I'm seeing enotices on drush 8.3.2 as it is looking for these to be keyed by 'description'

I believe this is fully backwards compatible to earlier drush versions

I'm seeing enotices on drush 8.3.2 as it is looking for these to be keyed by 'description'

I believe this is fully backwards compatible to earlier drush versions
@serundeputy
Copy link
Member

thanks @eileenmcnaughton !

This looks good to me, tests have stopped running since we need to migrate to travis-ci.com instead of org. I've put in a request for permission to migrate from a Backdrop-contrib org owner.

I'd like to see the tests run successfully, but if we don't hear from an owner in a few days we can probably just merge.

@eileenmcnaughton
Copy link
Contributor Author

Cool!

@serundeputy
Copy link
Member

@quicksketch did you receive an email request to allow travis-ci.com access to the backdrop-contrib/backdrop-drush-extension repo?

If so can you approve?

thanks,
~Geoff

@quicksketch
Copy link
Member

Hi @serundeputy! I did! Sorry I meant to approve it but it was buried. I have granted the Travis-CI app on all of backdrop-contrib.

@eileenmcnaughton
Copy link
Contributor Author

It still doesn't look like travis has run

@serundeputy
Copy link
Member

you are correct. It needs to be migrated which means, we need to opt it into the beta migration program which I think @quicksketch has to do.

If you can just verify for me that you've manually tested; I'll merge it in.

thanks.

@eileenmcnaughton
Copy link
Contributor Author

Yes - I manually tested it

@serundeputy serundeputy merged commit af29e23 into backdrop-contrib:1.x-1.x Jul 12, 2021
@serundeputy
Copy link
Member

thanks! merged.

@eileenmcnaughton eileenmcnaughton deleted the master branch July 12, 2021 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants