822 pspm pupil pp unit check #836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominikbach
requested changes
Mar 7, 2025
| @@ -225,6 +245,8 @@ | |||
| [sts, out_id] = pspm_write_channel(fn, smooth_signal, options.channel_action, o); | |||
| outchannel = out_id.channel; | |||
|
|
|||
| if con_flag == 1 , warning('At least one channel was converted to "mm". See details above.'); end | |||
There was a problem hiding this comment.
What does "see details above" refer to?
There was a problem hiding this comment.
If there is a conversion, a warning will be displayed (one per conversion). However, all the information about pupil preprocessing will still be shown afterward, which can be a lot. This serves as a reminder.
Like this:
src/pspm_pupil_pp_options.m
Outdated
| @@ -16,9 +16,9 @@ | |||
| % │ // Allowable values criteria | |||
| % │ | |||
| % ├─PupilDiameter_Min: Minimum allowable pupil size. Pupil values less than | |||
There was a problem hiding this comment.
Suggest: "Minimum allowable pupil size in mm"
and same in line 20
dominikbach
approved these changes
Mar 7, 2025
dominikbach
added
Approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #822 .
Changes proposed in this pull request: