Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: require connected and approved nodes for scheduling #3957

Merged
merged 4 commits into from
May 8, 2024
Merged

fix: require connected and approved nodes for scheduling #3957

merged 4 commits into from
May 8, 2024

Commits on May 8, 2024

  1. fix: require connected and approved nodes for scheduling 

    - fixes #3784
    @frrist
    frrist authored and frrist committed May 8, 2024
    Configuration menu
    Copy the full SHA
    68866fc View commit details
    Browse the repository at this point in the history

  2. refactor: selection constraints are an attribute of the NodeSelector 

    - cleans up some of the setup
    @frrist
    frrist authored and frrist committed May 8, 2024
    Configuration menu
    Copy the full SHA
    4421492 View commit details
    Browse the repository at this point in the history

  3. fix: in node_selection_test create a valid requester config 

    - previously the test set NodeRankRandomnessRange to 0 which ought to
  have paniced. But somehow it didn't? Addtionally the test produced a
  requester config that had an 'unknown' membership state, now the state
  is the default value: `Approved`. This change addess both the potential
  for a panic, and sets the correct membership status.

- More generlly, using mergo.Merge to reconcile config files is a shitty
  fucking pattern and needs to be purged from the codebase. It is far
  simpler to start with a default config and modify the fields that need
  to change for the test, instead of this overly complex circus fluster
  cluck that I just wasted 20mins of my life debugging. /rant
    @frrist
    frrist authored and frrist committed May 8, 2024
    Configuration menu
    Copy the full SHA
    3b94043 View commit details
    Browse the repository at this point in the history

  4. fix: RetriesSuite uses a valid config 

    - Ensures a request config is produced for testing that will not cause
  panics and has a default node membership state of 'Approved'.

- ffs same bug as previous commit, wonder how many more instances of
  this there are. *sobs into keyboard*
    @frrist
    frrist authored and frrist committed May 8, 2024
    Configuration menu
    Copy the full SHA
    87f1126 View commit details
    Browse the repository at this point in the history