Adds a node delete command
#3716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Important Auto Review SkippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the To trigger a single review, invoke the TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
aronchick
approved these changes
Mar 30, 2024
pkg/publicapi/apimodels/node.go
Outdated
| @@ -67,10 +68,12 @@ func (n NodeAction) Description() string { | |||
| return "Approve a node whose membership is pending" | |||
| case NodeActionReject: | |||
| return "Reject a node whose membership is pending" | |||
| case NodeActionDelete: | |||
| return "Delete a node from the cluster. Note this does not stop them re-connecting." | |||
There was a problem hiding this comment.
I don't think we need this warning. If a node disconnects, does it have to go pending again? (it should)
There was a problem hiding this comment.
Yes, would go back to Pending, unless whatever criteria we're using for auto-approve (tbd) puts them in that state.
rossjones
force-pushed
the
3715-node-delete-command
branch
from
94c3c82
to
d667849
Compare
Allows for nodes to be delete from the node info store. If the node is found in the store, it is deleted, and then will not re-appear when the requester node is re-started. If however the compute node restarts, it will re-register so this command is only useful if you know that nodes will not be coming back. In future if we want to block the node-id from ever being an entry, we should add tombstone entries to the node info store that blog it's registration.
rossjones
force-pushed
the
3715-node-delete-command
branch
from
d667849
to
8dac9fa
Compare
aronchick
pushed a commit
that referenced
this pull request
Apr 27, 2024
Allows for nodes to be delete from the node info store. If the node is found in the store, it is deleted, and then will not re-appear when the requester node is re-started. If however the compute node restarts, it will re-register so this command is only useful if you know that nodes will not be coming back. In future if we want to block the node-id from ever being an entry, we should add tombstone entries to the node info store that blog it's registration. Closes #3715
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows for nodes to be delete from the node info store. If the node is found in the store, it is deleted, and then will not re-appear when the requester node is re-started. If however the compute node restarts, it will re-register so this command is only useful if you know that nodes will not be coming back.
In future if we want to block the node-id from ever being an entry, we should add tombstone entries to the node info store that blog it's registration.
Closes #3715