[backport] chore: Refactor to start from the last finalized height (#257) #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #253. The poller should start from the `lastFinalizedHeight` other than `lastVotedHeight`. This is to deal with cases where the gap between the two heights is large so that the delay of catching up could cause jailing. This change will not give up many rewards because rewards are not assigned to late votes due to [ADR](https://github.com/babylonlabs-io/pm/blob/main/adr/adr-039-finality-voting-rewarding.md).
RafilxTenfen
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #253.
The poller should start from the
lastFinalizedHeightother thanlastVotedHeight. This is to deal with cases where the gap between the two heights is large so that the delay of catching up could cause jailing.This change will not give up many rewards because rewards are not assigned to late votes due to
ADR.