fix block tally in finality module #374
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RafilxTenfen
approved these changes
Jan 2, 2025
RafilxTenfen
reviewed
Jan 2, 2025
There was a problem hiding this comment.
Should we also remove the continue?
case fpSet == nil && !ib.Finalized:
// does not have finality providers, non-finalised: not finalisable,
// increment the next height to finalise and continue
k.setNextHeightToFinalize(ctx, ib.Height+1)
continue
edit: Ops, it goes to the for to continue, understood
KonradStaniec
added a commit
that referenced
this pull request
Jan 2, 2025
#350 Introduced regression due to change from if/else to switch. `break` which earlier was jumping out of the loop, after change would only exit the `switch` statement. Fix: - add `finalizationLoop` label and use it during `break` - add proper test to check that finalization in consecutive.
KonradStaniec
added a commit
that referenced
this pull request
Jan 2, 2025
#350 Introduced regression due to change from if/else to switch. `break` which earlier was jumping out of the loop, after change would only exit the `switch` statement. Fix: - add `finalizationLoop` label and use it during `break` - add proper test to check that finalization in consecutive.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#350 Introduced regression due to change from if/else to switch.
breakwhich earlier was jumping out of the loop, after change would only exit theswitchstatement.Fix:
finalizationLooplabel and use it duringbreak