Remove SKIP_NOT_SET_TESTS

GNUmakefile

@@ -49,9 +49,6 @@ testacc: fmtcheck
 	if [ -f .env ]; then set -o allexport; . ./.env; set +o allexport; fi; \
 	TF_ACC=1 go test -tags "$(TESTTAGS)" $(TEST) -v $(TESTARGS) -timeout 120m
 
-testacc-skip-tests: export SKIP_NOT_SET_TESTS=1
-testacc-skip-tests: testacc
-
 test-compile:
 	@if [ "$(TEST)" = "./..." ]; then \
 		echo "ERROR: Set TEST to a specific package. For example,"; \

README.md

@@ -121,7 +121,7 @@ With VSCode Golang extension you can also run and debug the tests using `run tes
 
 #### Acceptance tests
 
-The majority of tests in the provider are acceptance tests - which provisions real resources in Azure Devops and Azure. To run any acceptance tests you need to set `AZDO_ORG_SERVICE_URL`, `AZDO_PERSONAL_ACCESS_TOKEN` environment variables, some test have additional environment variables required to run. You can find out the required environment variables by running the test.
+The majority of tests in the provider are acceptance tests - which provisions real resources in Azure Devops and Azure. To run any acceptance tests you need to set `AZDO_ORG_SERVICE_URL`, `AZDO_PERSONAL_ACCESS_TOKEN` environment variables, some test have additional environment variables required to run. You can find out the required environment variables by running the test. Most of these variables can be set to dummy values.
 
 The several options to run the tests are:
 
@@ -137,12 +137,6 @@ The several options to run the tests are:
   make testacc TESTARGS='-run=TestAccBuildDefinitionBitbucket_Create' TESTTAGS='resource_build_definition'
   ```
 
-* Run all tests, but skip tests that have missing additional environment variables
-
-  ```sh
-  make testacc-skip-tests
-  ```
-
 * With VSCode Golang extension you can also run the tests using `run test`, `run package tests`, `run file tests` buttons above the test
 
 ##### Debugging acceptant tests

azuredevops/internal/acceptancetests/testutils/commons.go

@@ -52,10 +52,6 @@ func PreCheck(t *testing.T, additionalEnvVars *[]string) {
 
 	for _, variable := range requiredEnvVars {
 		if _, ok := os.LookupEnv(variable); !ok {
-			// Skip tests with missing additional environment variables when SKIP_NOT_SET_TESTS set
-			if _, ok := os.LookupEnv("SKIP_NOT_SET_TESTS"); ok && additionalEnvVars != nil {
-				t.Skipf("Skipping test %s. `%s` not set and required to run this test.", t.Name(), variable)
-			}
 			t.Fatalf("`%s` must be set for this acceptance test!", variable)
 		}
 	}