Skip to content

Add network_interface option to bind outgoing HTTP requests to a spec… #286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mmarwah wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add network_interface option to bind outgoing HTTP requests to a spec… #286

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions include/ulfius.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,6 +245,7 @@ struct _u_request {
int check_proxy_certificate_flag; /* !< check certificate peer and or proxy hostname if check_proxy_certificate is enabled, values available are U_SSL_VERIFY_PEER, U_SSL_VERIFY_HOSTNAME or both, default value is both (U_SSL_VERIFY_PEER|U_SSL_VERIFY_HOSTNAME), used by ulfius_send_http_request, requires libcurl >= 7.52 */
int follow_redirect; /* !< follow url redirections, used by ulfius_send_http_request */
char * ca_path; /* !< specify a path to CA certificates instead of system path, used by ulfius_send_http_request */
char * network_interface; /* !< bind outgoing socket to this interface/IP (CURLOPT_INTERFACE), used by ulfius_send_http_request */
unsigned long timeout; /* !< connection timeout used by ulfius_send_http_request, default is 0 */
struct sockaddr * client_address; /* !< IP address of the client */
char * auth_basic_user; /* !< basic authentication username */
Expand Down
4 changes: 4 additions & 0 deletions src/u_request.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,6 +287,7 @@ int ulfius_init_request(struct _u_request * request) {
request->http_url = NULL;
request->url_path = NULL;
request->proxy = NULL;
request->network_interface = NULL;
#if MHD_VERSION >= 0x00095208
request->network_type = U_USE_ALL;
#endif
Expand Down Expand Up @@ -327,6 +328,7 @@ int ulfius_clean_request(struct _u_request * request) {
o_free(request->http_url);
o_free(request->url_path);
o_free(request->proxy);
o_free(request->network_interface);
Copy link
Copy Markdown

@mnjdhl mnjdhl Apr 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Null check is not required before free?

Copy link
Copy Markdown
Author

@mmarwah mmarwah Apr 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Null check is done in o_free().

https://github.com/babelouest/orcania/blob/master/src/memory.c#L35

o_free(request->auth_basic_user);
o_free(request->auth_basic_password);
o_free(request->client_address);
Expand All @@ -340,6 +342,7 @@ int ulfius_clean_request(struct _u_request * request) {
request->http_verb = NULL;
request->http_url = NULL;
request->proxy = NULL;
request->network_interface = NULL;
request->client_address = NULL;
request->map_url = NULL;
request->map_header = NULL;
Expand Down Expand Up @@ -385,6 +388,7 @@ int ulfius_copy_request(struct _u_request * dest, const struct _u_request * sour
dest->http_url = o_strdup(source->http_url);
dest->url_path = o_strdup(source->url_path);
dest->proxy = o_strdup(source->proxy);
dest->network_interface = o_strdup(source->network_interface);
#if MHD_VERSION >= 0x00095208
dest->network_type = source->network_type;
#endif
Expand Down
9 changes: 9 additions & 0 deletions src/u_send_request.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -384,6 +384,15 @@ int ulfius_send_http_streaming_request_max_header(const struct _u_request * requ
}
}

// Bind outgoing socket to a specific network interface if set
if (copy_request->network_interface != NULL) {
if (curl_easy_setopt(curl_handle, CURLOPT_INTERFACE, copy_request->network_interface) != CURLE_OK) {
y_log_message(Y_LOG_LEVEL_ERROR, "Ulfius - Error setting network_interface option");
ret = U_ERROR_LIBCURL;
break;
}
}

// follow redirection if set
if (copy_request->follow_redirect) {
if (curl_easy_setopt(curl_handle, CURLOPT_FOLLOWLOCATION, 1) != CURLE_OK) {
Expand Down