Fixed flakiness of the test BABEL-3592 by analysing appropriate tables #3117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 11831313904Details
💛 - Coveralls |
added 3 commits
November 14, 2024 14:58
| Recheck Cond: (b1 = 1) | ||
| -> Bitmap Index Scan on index_babel_3592_t1_b1babel_35976c64b612d1f74e2768783beca3bf836 | ||
| Index Cond: (b1 = 1) | ||
| -> Insert on babel_3592_t2 (cost=0.00..0.00 rows=0 width=0) |
There was a problem hiding this comment.
Why there's still cost in here ?
There was a problem hiding this comment.
Please set babelfishpg_tsql.explain_costs to off
There was a problem hiding this comment.
This is experiment PR to understand difference
| @@ -8,7 +8,8 @@ | |||
| # new line | |||
| # 6. If you want the framework to not run certain files, use: ignore#!#<test name> | |||
|
|
|||
| all | |||
| # all | |||
| BABEL-3592 | |||
There was a problem hiding this comment.
THis is experimental PR
xhfanhe
reviewed
Nov 14, 2024
| Recheck Cond: (b1 = 1) | ||
| -> Bitmap Index Scan on index_babel_3592_t1_b1babel_35976c64b612d1f74e2768783beca3bf836 | ||
| Index Cond: (b1 = 1) | ||
| -> Insert on babel_3592_t2 (cost=0.00..0.00 rows=0 width=0) |
There was a problem hiding this comment.
Please set babelfishpg_tsql.explain_costs to off
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This commit aims to fix flakiness of the test BABEL-3592 by analysing appropriate tables
Signed-off-by: Dipesh Dhameliya dddhamel@amazon.com
Check List
By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.