Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TVP as an argument of a procedure does not require TypeName to be specified #3107

Open
wants to merge 9 commits into
base: BABEL_4_X_DEV
Choose a base branch
from

Conversation

tanyagupta17
Copy link
Contributor

@tanyagupta17 tanyagupta17 commented Nov 13, 2024

Description

The type name of the specified table-valued parameter as an argument for a procedure should be optional. Currently, babelfish does not support this since we need explicit type to create the temp table.

We are fixing it by doing a look up of the typename of the TVP argument based on procedure name, namespace, db and role and setting the same.

Signed-off-by: Tanya Gupta tanyagp@amazon.com

Issues Resolved

BABEL-5311

Test Scenarios Covered

  • Use case based - Yes

  • Boundary conditions - NA

  • Arbitrary inputs - Yes

  • Negative test cases - NA

  • Minor version upgrade tests - Yes

  • Major version upgrade tests - Yes

  • Performance tests - NA

  • Tooling impact - NA

  • Client tests - Yes

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.

For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…cified

Signed-off-by: Tanya Gupta <tanyagp@amazon.com>
@tanyagupta17 tanyagupta17 changed the title TVP as an argument of a procedure does not require TypeName to be spe… TVP as an argument of a procedure does not require TypeName to be specified Nov 13, 2024
@coveralls
Copy link
Collaborator

coveralls commented Nov 13, 2024

Pull Request Test Coverage Report for Build 11831522141

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 84 of 85 (98.82%) changed or added relevant lines in 4 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.03%) to 74.69%

Changes Missing Coverage Covered Lines Changed/Added Lines %
contrib/babelfishpg_tds/src/include/tds_request.h 77 78 98.72%
Files with Coverage Reduction New Missed Lines %
contrib/babelfishpg_tds/src/backend/tds/tdscomm.c 2 76.03%
Totals Coverage Status
Change from base Build 11818101440: 0.03%
Covered Lines: 45496
Relevant Lines: 60913

💛 - Coveralls

Tanya Gupta added 7 commits November 13, 2024 07:26
Signed-off-by: Tanya Gupta <tanyagp@amazon.com>
Signed-off-by: Tanya Gupta <tanyagp@amazon.com>
Signed-off-by: Tanya Gupta <tanyagp@amazon.com>
TVP argument type oid and typename

Signed-off-by: Tanya Gupta <tanyagp@amazon.com>
Signed-off-by: Tanya Gupta <tanyagp@amazon.com>
Signed-off-by: Tanya Gupta <tanyagp@amazon.com>
Signed-off-by: Tanya Gupta <tanyagp@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants