Execute CREATE/GRANT ROLE statements using bbf_role_admin during restore #3082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rishabh Tanwar <ritanwar@amazon.com>
Signed-off-by: Rishabh Tanwar <ritanwar@amazon.com>
Signed-off-by: Rishabh Tanwar <ritanwar@amazon.com>
Pull Request Test Coverage Report for Build 11890286888Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Signed-off-by: Rishabh Tanwar <ritanwar@amazon.com>
Signed-off-by: Rishabh Tanwar <ritanwar@amazon.com>
Signed-off-by: Rishabh Tanwar <ritanwar@amazon.com>
Signed-off-by: Rishabh Tanwar <ritanwar@amazon.com>
Signed-off-by: Rishabh Tanwar <ritanwar@amazon.com>
shalinilohia50
approved these changes
Nov 18, 2024
Comment on lines
+3843
to
+3859
| /* | ||
| * First execute REVOKE statement using bootstrap user. | ||
| * This is needed since grantor of GRANTs from previous versions might | ||
| * not be bbf_role_admin. | ||
| */ | ||
| SetUserIdAndSecContext(BOOTSTRAP_SUPERUSERID, save_sec_context | SECURITY_LOCAL_USERID_CHANGE); | ||
| PG_TRY(); | ||
| { | ||
| call_prev_ProcessUtility(pstmt, queryString, readOnlyTree, context, params, | ||
| queryEnv, dest, qc); | ||
| } | ||
| PG_FINALLY(); | ||
| { | ||
| /* Clean up. Restore previous state. */ | ||
| SetUserIdAndSecContext(save_userid, save_sec_context); | ||
| } | ||
| PG_END_TRY(); |
There was a problem hiding this comment.
Can we identify those faulty GRANT and correct those in upgrade?
There was a problem hiding this comment.
Or Is it possible to escalate to BOOTSTRAP_SUPERUSERID in some of the cases only? Are there any alternatives apart from we escalate to BOOTSTRAP_SUPERUSERID -- using somewhat less-privileged user?
Comment on lines
+3911
to
+3912
| if (isadmin) | ||
| break; |
There was a problem hiding this comment.
Please explain this.
| if (isadmin) | ||
| break; | ||
|
|
||
| /* Save the previous user to be restored after creating the login. */ |
There was a problem hiding this comment.
after creating the login?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Execute CREATE/GRANT ROLE statements using bbf_role_admin during restore
so that bbf_role_admin becomes the admin/GRANTOR. We will do this only if the
current is superuser since only superuser is allowed to perform dump/restore.
Note that no additional permission checks are needed as superusers can anyway
perform this action.
Additionally, even revoke grants GRANTED by BOOTSTRAP_SUPERUSER since grantor
of GRANTs from previous versions might be bbf_role_admin.
Task: BABEL-5309
Signed-off-by: Rishabh Tanwar ritanwar@amazon.com
Test Scenarios Covered
Use case based -
Boundary conditions -
Arbitrary inputs -
Negative test cases -
Minor version upgrade tests -
Major version upgrade tests -
Performance tests -
Tooling impact -
Client tests -
Check List
By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.