Use plain js to do the pre/postpublish for the polyfill #3694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danez
added
the
PR: Internal 🏠
danez
force-pushed
the
remove-shelljs
branch
from
e95ea08
to
56eb8d2
Compare
Current coverage is 88.32% (diff: 100%)@@ master #3694 diff @@
==========================================
Files 194 194
Lines 13611 13611
Methods 1427 1427
Messages 0 0
Branches 3142 3142
==========================================
Hits 12022 12022
Misses 1589 1589
Partials 0 0
|
|
Actually I'm not even sure where that gets run? https://github.com/babel/babel/blob/master/Makefile#L12 just calls the other script Also it doesn't seem like we clear it correctly. |
|
I'm not entirely sure if it is working, but I think lerna is calling it: https://github.com/lerna/lerna/blob/1cd6366f60e6a7f180b5490c9c5b1b6688bc9e66/src/commands/PublishCommand.js#L343 |
|
What do you mean with "we don't clear it correctly"? |
|
Ok I thought we remove rm -rf dist/polyfill.js as well in the clean task
|
|
Ah okay, I'm not sure if we should do that on postpublish in babel-polyfill... |
panagosg7
pushed a commit
to panagosg7/babel
that referenced
this pull request
Jan 17, 2017
* Use plain js to do the pre/postpublish for the polyfill * remove dist on clean [skip ci]
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We only use shelljs for these two scripts, so it is not really necessary I think.