Fix backward-compatibility of babel-preset-es2015 - fixes T7536 #3635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loganfsmyth
force-pushed
the
fix-back-compat
branch
from
d6fcfb7
to
66317b1
Compare
| Object.defineProperty(module.exports, "buildPreset", { | ||
| configurable: true, | ||
| writable: true, | ||
| enumerable: false, |
There was a problem hiding this comment.
Probably worth noting why this has to be non-enumerable, to avoid triggering the check for unknown options
|
For those coming here still trying to fix their builds, upgrade your babel-core to the latest to solve the issue; and/or any dep that includes babel-core like babel-cli, etc. This PR is about fixing the issue for people who don't upgrade their babel-core. |
| @@ -4,7 +4,8 @@ var expect = require("chai").expect; | |||
|
|
|||
| suite("es2015 preset", function () { | |||
| test("exposes a function", function () { | |||
There was a problem hiding this comment.
This is probably inaccurate now :>
eventualbuddha
added a commit
that referenced
this pull request
Aug 5, 2016
Originally pointed out by @Kovensky in #3635 (comment).
hzoo
pushed a commit
that referenced
this pull request
Aug 5, 2016
Originally pointed out by @Kovensky in #3635 (comment).
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.