Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix config issue in example #708

Merged
merged 1 commit into from
Oct 19, 2018
Merged

Fix config issue in example #708

merged 1 commit into from
Oct 19, 2018

Conversation

alexturpin
Copy link
Contributor

Please check if the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe: Documentation fixes

What is the current behavior? (You can also link to an open issue here)
The README contained an example that if used caused an error .default is not a valid Plugin property

What is the new behavior?
The README example was fixed. No more errors if the example is used.

Does this PR introduce a breaking change?

  • Yes
  • No

If this PR contains a breaking change, please describe the following...

  • Impact:
  • Migration path for existing applications:
  • Github Issue(s) this is regarding:

Other information:

@loganfsmyth loganfsmyth merged commit 1bda840 into babel:master Oct 19, 2018
@loganfsmyth
Copy link
Member

Thanks!

@alexturpin alexturpin deleted the alexturpin-patch-1 branch October 19, 2018 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants