Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md for webpack 2 #402

Merged
merged 1 commit into from
Mar 2, 2017
Merged

Update README.md for webpack 2 #402

merged 1 commit into from
Mar 2, 2017

Conversation

sidraval
Copy link
Contributor

@sidraval sidraval commented Mar 1, 2017

Please check if the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?
Currently, the babel loader section of the webpack 2 documentation is outdated.

What is the new behavior?
I've fixed the links in the readme to point to the new webpack documentation, and updated the examples to webpack 2 style. I also incorporated the logo changes &c. from #355

Does this PR introduce a breaking change?

  • Yes
  • No

Other information:
I just went through a webpack 2 setup on a project, noticed this documentation was out of date, and thought I'd change it as I went!

@codecov
Copy link

codecov bot commented Mar 1, 2017

Codecov Report

Merging #402 into 7.0 will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              7.0     #402   +/-   ##
=======================================
  Coverage   81.87%   81.87%           
=======================================
  Files           6        6           
  Lines         160      160           
  Branches       35       35           
=======================================
  Hits          131      131           
  Misses         13       13           
  Partials       16       16

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a483384...f05bff4. Read the comment docs.

@danez
Copy link
Member

danez commented Mar 2, 2017

Thank you very much, this is awesome.

@danez danez merged commit 7e0d776 into babel:7.0 Mar 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants