fix: mark webpack as optional peer dependency#1061
Conversation
There was a problem hiding this comment.
Pull request overview
This PR enables babel-loader to work with both webpack and Rspack by marking both as optional peer dependencies. This allows users to choose either bundler without requiring both to be installed.
Changes:
- Added
@rspack/coreas an optional peer dependency with version range^1.0.0 || ^2.0.0-0 - Marked both
@rspack/coreandwebpackas optional inpeerDependenciesMeta - Updated README.md description to mention Rspack support alongside webpack
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| package.json | Added @rspack/core as optional peer dependency and configured peerDependenciesMeta to mark both webpack and @rspack/core as optional |
| README.md | Updated package description to indicate support for both webpack and Rspack |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
a4de967 to
a886527
Compare
a886527 to
e562742
Compare
|
Thank you! Could you update the tests to test rspack compatibility? |
|
Sure! I have updated all test cases to test both webpack and Rspack. |
|
@nicolo-ribaudo When you have a chance, please take a look. Thanks! |
nicolo-ribaudo
left a comment
There was a problem hiding this comment.
Thank you! @JLHwung could you also take a look since you have more experience with this codebase?
Summary
@rspack/coreas an optional peer dependencypeerDependenciesMetato mark both@rspack/coreandwebpackas optionalREADME.mdnow mentions that babal-loader can be used with bothwebpackandRspack