Skip to content

Commit

Permalink
Remove mock tests
Browse files Browse the repository at this point in the history 
I cannot manage to get that reliably working, somehow mock-fs
is messing up ava/mkdirp/rimraf and makes ava hang forever on error
  • Loading branch information
@danez
danez committed Dec 15, 2016
1 parent 48f2725 commit 24a6aa4
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 156 deletions.
1 change: 0 additions & 1 deletion package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@
"eslint-config-babel": "^3.0.0",
"eslint-plugin-babel": "^4.0.0",
"eslint-plugin-flowtype": "^2.25.0",
"mock-fs": "^3.12.1",
"nyc": "^10.0.0",
"rimraf": "^2.4.3",
"webpack": "^2.2.0-rc"
Expand Down
141 changes: 0 additions & 141 deletions test/cache.test.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ import path from "path";
import assign from "object-assign";
import rimraf from "rimraf";
import webpack from "webpack";
// import mock from "mock-fs";
import createTestDirectory from "./helpers/createTestDirectory";

const defaultCacheDir = path.join(__dirname, "../node_modules/.cache/babel-loader");
Expand Down Expand Up @@ -320,143 +319,3 @@ test.cb("should allow to specify the .babelrc file", (t) => {
});
});
});

// TODO all the following tests should be done without webpack, as the combination
// of mock-fs and webpack seems to be not reliable.

// test.cb.serial("has error if custom cache directory cannot be created", (t) => {
// const config = assign({}, globalConfig, {
// output: {
// path: t.context.directory,
// },
// module: {
// loaders: [
// {
// test: /\.jsx?/,
// loader: babelLoader,
// exclude: /node_modules/,
// query: {
// cacheDirectory: t.context.cacheDirectory,
// presets: [],
// babelrc: false,
// },
// },
// ],
// },
// });
//
// mock({
// [path.dirname(t.context.cacheDirectory)]: mock.directory({
// mode: 0o444,
// })
// });
// webpack(config, (err, stats) => {
// t.is(err, null);
// t.is(stats.hasErrors(), true);
// t.regex(stats.toJson().errors[0], /EACCES, permission denied/);
// mock.restore();
// t.end();
// });
// });
//
// test.cb.serial("falls back to tmp dir if default dir is not writable", (t) => {
// const config = assign({}, globalConfig, {
// output: {
// path: t.context.directory,
// },
// module: {
// loaders: [
// {
// test: /\.jsx?/,
// loader: babelLoader,
// exclude: /node_modules/,
// query: {
// cacheDirectory: true,
// presets: [],
// babelrc: false,
// },
// },
// ],
// },
// });
//
// mock({
// [path.join(__dirname, "../package.json")]: mock.file(),
// [path.dirname(defaultCacheDir)]: mock.directory({
// mode: 0o444,
// })
// });
// webpack(config, (err, stats) => {
// t.is(err, null);
// t.is(stats.hasErrors(), false);
// mock.restore();
// t.end();
// });
// });
//
// test.cb.serial("falls back to tmp dir if no cache dir found", (t) => {
// const config = assign({}, globalConfig, {
// output: {
// path: t.context.directory,
// },
// module: {
// loaders: [
// {
// test: /\.jsx?/,
// loader: babelLoader,
// exclude: /node_modules/,
// query: {
// cacheDirectory: true,
// presets: [],
// babelrc: false,
// },
// },
// ],
// },
// });
//
// mock({
// [path.dirname(defaultCacheDir)]: mock.directory({
// mode: 0o444,
// })
// });
// webpack(config, (err, stats) => {
// t.is(err, null);
// t.is(stats.hasErrors(), false);
// mock.restore();
// t.end();
// });
// });
//
//
// test.cb.serial("reports errors from babel transpile", (t) => {
// const config = assign({}, globalConfig, {
// output: {
// path: t.context.directory,
// },
// module: {
// loaders: [
// {
// test: /\.jsx?/,
// loader: babelLoader,
// exclude: /node_modules/,
// query: {
// cacheDirectory: true,
// presets: ["es2015"],
// },
// },
// ],
// },
// });
//
// mock();
// webpack(config, (err, stats) => {
// t.is(err, null);
// t.is(stats.hasErrors(), true);
// t.regex(stats.toJson().errors[0], /ENOENT, no such file or directory/);
// t.regex(stats.toJson().errors[0], /\.babelrc/);
// mock.restore();
// t.end();
// });
// });

17 changes: 3 additions & 14 deletions yarn.lock
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2871,13 +2871,6 @@ minimist@^1.1.3, minimist@^1.2.0:
dependencies:
minimist "0.0.8"

mock-fs@^3.12.1:
version "3.12.1"
resolved "https://registry.yarnpkg.com/mock-fs/-/mock-fs-3.12.1.tgz#ff27824cd6ab263a7eb05a115239d41d3631f5f8"
dependencies:
rewire "2.5.2"
semver "5.3.0"

ms@0.7.1:
version "0.7.1"
resolved "https://registry.yarnpkg.com/ms/-/ms-0.7.1.tgz#9cd13c03adbff25b65effde7ce864ee952017098"
Expand Down Expand Up @@ -3422,7 +3415,7 @@ read-pkg@^1.0.0:
normalize-package-data "^2.3.2"
path-type "^1.0.0"

readable-stream@^2.0.0, "readable-stream@^2.0.0 || ^1.1.13", readable-stream@^2.0.1, readable-stream@^2.0.5, readable-stream@^2.1.0, readable-stream@^2.1.5:
readable-stream@^2.0.0, "readable-stream@^2.0.0 || ^1.1.13", readable-stream@^2.1.0, readable-stream@^2.1.5:
version "2.2.2"
resolved "https://registry.yarnpkg.com/readable-stream/-/readable-stream-2.2.2.tgz#a9e6fec3c7dda85f8bb1b3ba7028604556fc825e"
dependencies:
Expand All @@ -3434,7 +3427,7 @@ readable-stream@^2.0.0, "readable-stream@^2.0.0 || ^1.1.13", readable-stream@^2.
string_decoder "~0.10.x"
util-deprecate "~1.0.1"

readable-stream@^2.0.2, readable-stream@~2.0.0:
readable-stream@^2.0.1, readable-stream@^2.0.2, readable-stream@^2.0.5, readable-stream@~2.0.0:
version "2.0.6"
resolved "https://registry.yarnpkg.com/readable-stream/-/readable-stream-2.0.6.tgz#8f90341e68a53ccc928788dacfcd11b36eb9b78e"
dependencies:
Expand Down Expand Up @@ -3623,10 +3616,6 @@ restore-cursor@^1.0.1:
exit-hook "^1.0.0"
onetime "^1.0.0"

rewire@2.5.2:
version "2.5.2"
resolved "https://registry.yarnpkg.com/rewire/-/rewire-2.5.2.tgz#6427de7b7feefa7d36401507eb64a5385bc58dc7"

right-align@^0.1.1:
version "0.1.3"
resolved "https://registry.yarnpkg.com/right-align/-/right-align-0.1.3.tgz#61339b722fe6a3515689210d24e14c96148613ef"
Expand Down Expand Up @@ -3665,7 +3654,7 @@ semver-diff@^2.0.0:
dependencies:
semver "^5.0.3"

"semver@2 || 3 || 4 || 5", semver@5.3.0, semver@^5.0.3, semver@^5.1.0, semver@^5.3.0, semver@~5.3.0:
"semver@2 || 3 || 4 || 5", semver@^5.0.3, semver@^5.1.0, semver@^5.3.0, semver@~5.3.0:
version "5.3.0"
resolved "https://registry.yarnpkg.com/semver/-/semver-5.3.0.tgz#9b2ce5d3de02d17c6012ad326aa6b4d0cf54f94f"

Expand Down

0 comments on commit 24a6aa4

Please sign in to comment.