This repository was archived by the owner on Aug 18, 2021. It is now read-only.
Repository navigation
change more tokentypes to be punctuator - fixes #59 - #90
Merged
Merged
Conversation
sebmck
added a commit
that referenced
this pull request
May 11, 2015
change more tokentypes to be punctuator - fixes #59
Contributor
|
Nope, definently want them all. Thanks! |
wcjohnson
added a commit
to wcjohnson/lightscript-eslint
that referenced
this pull request
Oct 2, 2018
- Disable `array-callback-return` - Disable `react/require-render-return` - Monkeypatch `fp/no-nil` Re wcjohnson/lightscript#90
nicolo-ribaudo
pushed a commit
to babel/babel
that referenced
this pull request
Nov 14, 2019
change more tokentypes to be punctuator - fixes babel/babel-eslint#59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#59.
Came across as similar issue in jscs as well. Some of the rules are checking something like
op.type === "Punctuator"but some of the types are stillTokenTyperather than a string.I basically just added everything in https://github.com/babel/babel/blob/master/src/acorn/src/tokentype.js#L48-L96 that wasn't already there.
I'm not sure we want all of these though?