ci: drop testing of jdk8 on macos #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**circleci: configuring for Apple silicon** I could not find a combination of an m1 `resource_class` and `xcode` that did not produce a "not available for your project" error from CircleCI. So I left out `resource_class` for now. Perhaps all will be good after Apple Silicon is the only supportted macos executor on June 29, 2024. I'll come back and check on this an open a new issue if necessary. **circleci: jdk: infer os and architecture from host** JDK architecture was hardcoded to x64 but this is not appropriate for our new Apple silicone hardware. We now infer architecture from host. Figured might as well infer os from host as well. Adjusted install dir name to include os and architecture to support testability and a potential future where one might, for example, install x64 on Apple Silicon hardware and use Rosetta. The latter would require a tweak to allow architecture to be selected by the user. We'll allow for that in the future should we need it. Closes babashka#153
|
A vague memory of a confusing thing: your CircleCI checks don't run on PRs, maybe? |
|
Seems to run fine |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
circleci: configuring for Apple silicon
I could not find a combination of an m1
resource_classandxcodethat did not produce a "not available for your project" error from CircleCI. So I left outresource_classfor now. Perhaps all will be good after Apple Silicon is the only supportted macos executor on June 29, 2024. I'll come back and check on this an open a new issue if necessary.circleci: jdk: infer os and architecture from host
JDK architecture was hardcoded to x64 but this is not appropriate for our new Apple silicone hardware. We now infer architecture from host.
Figured might as well infer os from host as well.
Adjusted install dir name to include os and architecture to support testability and a potential future where one might, for example, install x64 on Apple Silicon hardware and use Rosetta. The latter would require a tweak to allow architecture to be selected by the user. We'll allow for that in the future should we need it.
Closes #153