Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to jQuery 3 #247

Closed
jasverix opened this issue Sep 10, 2018 · 1 comment
Closed

Upgrade to jQuery 3 #247

jasverix opened this issue Sep 10, 2018 · 1 comment

Comments

@jasverix
Copy link

I think your package already works with jQuery 3 - but the package.json requires jQuery 2. Maybe it is just to increase version number there.

Output from npm audit

> npm audit

                       === npm audit security report ===


                                 Manual Review
             Some vulnerabilities require your attention to resolve

          Visit https://go.npm.me/audit-guide for additional guidance


  High            Cross-Site Scripting (XSS)

  Package         jquery

  Patched in      >=3.0.0

  Dependency of   persian-datepicker

  Path            persian-datepicker > jquery

  More info       https://nodesecurity.io/advisories/328

found 1 high severity vulnerability
@JohnAdib
Copy link

No it not work with jquey3
need some change like

  1. change all .bind( to .on(
  2. change all .unbind( to .off(
  3. remove shorthand method call. change .keydown(function to .on("keydown", function

https://stackoverflow.com/questions/38276594/upgrade-jquery-to-3-0-rewrite-bind-to-on-unbind-to-off

babakhani added a commit that referenced this issue Feb 8, 2019
babakhani added a commit that referenced this issue Feb 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants