Repository navigation
Conversation
b7r6
force-pushed
the
fix/store-keepalive-retry
branch
2 times, most recently
from
October 7, 2026 20:31
7ac5548 to
9c6bbf0
Compare
…keepalive_ts, retiring a live client's action as abandoned Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…l timestamp In OperationSubscriber::changed (USE_SEPARATE_CLIENT_KEEPALIVE_KEY branch), a failed ck_* store write still advanced the local last_known_keepalive_ts and then parked for a full CLIENT_KEEPALIVE_DURATION. Peer replicas judge client liveness solely from the store, so a couple of consecutive transient store failures (Redis blip) left the store's keepalive stamp aging past client_action_timeout and a peer's sweep retired the live client's action as abandoned. Now the local timestamp only advances on a successful write; on failure the sleep becomes a bounded CLIENT_KEEPALIVE_RETRY_DELAY (1s) so the write is retried promptly without spinning when the store is down hard. Repro test fails before the fix (attempts = 1 across 3x keepalive periods) and passes after. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
b7r6
force-pushed
the
fix/store-keepalive-retry
branch
from
October 8, 2026 17:51
9c6bbf0 to
67505a6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Lane A stability fix from the findings catalog (see
nativelink-findings-2026-10-05.csvon the
meta/findings-catalog-2026-10-05branch), rebased onto OSS main@bf4b3aa855. This fork PR exists to validate the change on CI that is
representative of upstream PR lanes (public read-only cache, same endpoints)
before any upstream submission.
How was this verified?
The branch carries its own regression tests (fails-without where the fix
class allows it — see the branch's test commits). This PR's purpose is the
full representative CI run; green here rehearses the exact checks an
upstream PR would face.
Risk
Fork-internal validation PR; nothing lands anywhere by merging this. The
underlying fix's risk assessment happens at upstream-submission time.
AI assistance
Agent-assisted pipeline (Claude) for rebase and PR mechanics under my
direction; the fix itself carries verification in its tests.