[Review] Request from 'xystushi' @ 'xystushi/git-review/review_130812_send_pull_requests_to_upstream' #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move code into more appropriate methods in Github and Local classes.
|
I haven't yet tried it, but the code looks good. BTW: If you want to change an existing pull request, you could just push additional commits to an existing one (even if there are already some comments). Just push to the referenced branch. So I guess it wasn't really necessary to close the other request and open up this new one. Nevertheless, this worked, too. So why bother about the past. |
b4mboo
added a commit
that referenced
this pull request
Aug 14, 2013
…_to_upstream [Review] Request from 'xystushi' @ 'xystushi/git-review/review_130812_send_pull_requests_to_upstream'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review the following changes:
and, use&&always.