-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: bump up cosmos sdk v0.50.x and cometbft v0.38.0 #2
feat: bump up cosmos sdk v0.50.x and cometbft v0.38.0 #2
Conversation
cosmos-sdk v0.47.0 cometbft v0.37.0 cometbft-db v0.7.0 ibc-go/v7 v7.0.0 cosmos-proto v1.0.0-beta.2 (downgrade) cosmossdk.io/simapp v0.0.0-20230323161446-0af178d721fffeat: bump up ibc-go/v7 v7.0.0
* Problem: localhost client param is not migrated for more info, https://github.com/cosmos/ibc-go/blob/v7.2.0/docs/migrations/v7-to-v7_1.md * add test * fix test * WithConsensusParamsGetter to MigrationModuleManager
…ng messages in check tx mode (evmos#327) * small fixes (evmos#310) * disable vesting account messages in check tx * Problem: don't support blocking addresses Solution: - support block addresses in mempool * fix error * put block address logic after validate basic * fix build * Apply suggestions from code review Signed-off-by: yihuang <huang@crypto.com> --------- Signed-off-by: yihuang <huang@crypto.com> * rm IsCheckTx check --------- Signed-off-by: yihuang <huang@crypto.com> Co-authored-by: yihuang <huang@crypto.com>
…vmos#350) Solution: - re-order ante handlers, use cached from address
* fix negative dynamic fee * Update app/ante/fee_checker.go Signed-off-by: yihuang <huang@crypto.com> * fix build --------- Signed-off-by: yihuang <huang@crypto.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I leave some comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The review is still in progress, but let me leave part of what I discovered
- I think the
sdk.AttributeKeyModule
andsdk.AttributeKeySender
attributes ofEventTypeMessage
have been modified to emit automatically starting from sdk v0.47, as per the reference. It seems necessary to review and revise to ensure that this isn't leading to the duplicate emission of events. ( onmsg_server.go
) - I've been keeping an eye on it as well, but it seems we need to ensure that any differences between versions 0.47 and 0.50 have been fully addressed.
- For the workflows that are failing before release, if there are items that don't need fixing, we should exclude them from the workflow. However, if they require fixing, it would be better to address those issues.
Closes: #XXX
Description
Key dependency changes:
notable changed files
app
rpc
modules
autocli
, so removes contents of tx.go, query.goValidateBasic
logic to msg_serverprotobuf
. But in case ofMsgEthereumTx
, GetSigners func is alive and implemented GetSignersFromMsgEthereumTxV2 func additionally.(ref. feat: bump up cosmos-sdk v0.50.x, cometbft v0.38.x Canto#53 (comment))msg level
soauthority
has been added to the required module.(ref. Add CLI command to submit new Gov proposals, using Msgs cosmos/cosmos-sdk#10952)KVStoreService
as opposed to the prev way of accessing KVStore via store key.(ref. refactor(x/staking)!: KVStoreService, return errors and use context.Context cosmos/cosmos-sdk#16324, ...)NOTE
go.mod
are upgraded, need to ensure that there are no security issues.For contributor use:
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerFor admin use:
WIP
,R4R
,docs
, etc)