Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bump up cosmos sdk v0.50.x and cometbft v0.38.0 #2

Merged

Conversation

dudong2
Copy link
Collaborator

@dudong2 dudong2 commented Nov 29, 2023

Closes: #XXX

Description

Key dependency changes:

  • Cosmos-SDK v0.45.9 to v0.50.6
  • CometBFT (Tendermint) v0.34.25 to v0.38.6
  • ibc-go v3.2.0 to v8.2.1
  • go-ethereum v1.10.19 to v1.10.26

notable changed files

app/app.go
app/ante/ante.go
app/ante/handler_options.go
app/upgrades.go
encoding/config.go
server/start.go
server/util.go
rpc/backend/sign_tx.go
rpc/backend/node_info.go
rpc/namespaces/ethereum/eth/filters/api.go
rpc/namespaces/ethereum/eth/filters/filter_system.go
x/feemarket/types/msg.go
x/feemarket/keeper/keeper.go
x/feemarket/keeper/msg_server.go
x/feemarket/autocli.go
x/feemarket/module.go
x/evm/types/msg.go
x/evm/keeper/keeper.go
x/evm/keeper/msg_server.go
x/evm/autocli.go
x/evm/module.go
go.mod

app

rpc

  • as go-ethereum versions go up, the implementation of funcs used internally may have changed

modules

NOTE

  • as the versions of different modules in go.mod are upgraded, need to ensure that there are no security issues.

For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

dudong2 and others added 20 commits November 14, 2023 18:58
cosmos-sdk v0.47.0
cometbft v0.37.0
cometbft-db v0.7.0
ibc-go/v7 v7.0.0
cosmos-proto v1.0.0-beta.2 (downgrade)
cosmossdk.io/simapp v0.0.0-20230323161446-0af178d721fffeat: bump up ibc-go/v7 v7.0.0
* Problem: localhost client param is not migrated

for more info, https://github.com/cosmos/ibc-go/blob/v7.2.0/docs/migrations/v7-to-v7_1.md

* add test

* fix test

* WithConsensusParamsGetter to MigrationModuleManager
…ng messages in check tx mode (evmos#327)

* small fixes (evmos#310)

* disable vesting account messages in check tx

* Problem: don't support blocking addresses

Solution:
- support block addresses in mempool

* fix error

* put block address logic after validate basic

* fix build

* Apply suggestions from code review

Signed-off-by: yihuang <huang@crypto.com>

---------

Signed-off-by: yihuang <huang@crypto.com>

* rm IsCheckTx check

---------

Signed-off-by: yihuang <huang@crypto.com>
Co-authored-by: yihuang <huang@crypto.com>
…resses in mempool and disable vesting messages in check tx mode (evmos#327)"

This reverts commit 1533fc1.
…vmos#350)

Solution:
- re-order ante handlers, use cached from address
…ause of un-cached sender recovery (evmos#350)"

This reverts commit f0c4147.
* fix negative dynamic fee

* Update app/ante/fee_checker.go

Signed-off-by: yihuang <huang@crypto.com>

* fix build

---------

Signed-off-by: yihuang <huang@crypto.com>
@dudong2 dudong2 requested a review from zsystm February 5, 2024 08:05
Copy link
Collaborator

@zsystm zsystm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I leave some comments

app/app.go Outdated Show resolved Hide resolved
app/export.go Show resolved Hide resolved
app/export.go Show resolved Hide resolved
ethereum/eip712/message.go Show resolved Hide resolved
ethereum/eip712/eip712_test.go Show resolved Hide resolved
rpc/namespaces/ethereum/eth/filters/api.go Outdated Show resolved Hide resolved
testutil/network/network.go Show resolved Hide resolved
server/cmt_abci.go Show resolved Hide resolved
client/testnet.go Outdated Show resolved Hide resolved
rpc/namespaces/ethereum/eth/filters/api.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@zsystm zsystm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@dongsam dongsam self-requested a review March 12, 2024 02:30
Copy link
Member

@dongsam dongsam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review is still in progress, but let me leave part of what I discovered

  • I think the sdk.AttributeKeyModuleand sdk.AttributeKeySender attributes of EventTypeMessage have been modified to emit automatically starting from sdk v0.47, as per the reference. It seems necessary to review and revise to ensure that this isn't leading to the duplicate emission of events. ( on msg_server.go )
  • I've been keeping an eye on it as well, but it seems we need to ensure that any differences between versions 0.47 and 0.50 have been fully addressed.
  • For the workflows that are failing before release, if there are items that don't need fixing, we should exclude them from the workflow. However, if they require fixing, it would be better to address those issues.

go.mod Outdated Show resolved Hide resolved
@dudong2 dudong2 changed the base branch from main to canto-v8/develop July 2, 2024 07:12
@dudong2 dudong2 merged commit 2d35118 into canto-v8/develop Jul 2, 2024
27 of 42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants