Integrate @azure/eslint-plugin-azure-sdk (#4772)

* setup for service-bus * add to keyvault-certificates * add .eslintrc * add to keyvault-keys * add to keyvault-secrets * add to event-hubs * add to event-processor-host * bump to 2.0.1 * add to core-auth * add to core-tracing * add to core-amqp * add to core-http * clean rush update * Update lock file * fix lint steps for kevault * update pnpm-lock file
azure-sdk · Sep 20, 2019 · 1d6c7fd · 1d6c7fd
1 parent 60f4d2d
commit 1d6c7fd
Show file tree

Hide file tree

Showing 21 changed files with 124 additions and 57 deletions.
diff --git a/common/config/rush/pnpm-lock.yaml b/common/config/rush/pnpm-lock.yaml
diff --git a/sdk/core/core-amqp/.eslintrc.json b/sdk/core/core-amqp/.eslintrc.json
@@ -0,0 +1,7 @@
+{
+  "plugins": ["@azure/azure-sdk"],
+  "extends": ["../../.eslintrc.json", "plugin:@azure/azure-sdk/recommended"],
+  "parserOptions": {
+    "createDefaultProgram": true
+  }
+}
diff --git a/sdk/core/core-amqp/package.json b/sdk/core/core-amqp/package.json
@@ -32,8 +32,8 @@
     "integration-test:browser": "echo skipped",
     "integration-test:node": "echo skipped",
     "integration-test": "npm run integration-test:node && npm run integration-test:browser",
-    "lint:fix": "eslint -c ../../.eslintrc.json src test samples --ext .ts --fix",
-    "lint": "eslint -c ../../.eslintrc.json src test samples --ext .ts -f html -o core-amqp-lintReport.html || exit 0",
+    "lint:fix": "eslint package.json tsconfig.json src test samples --ext .ts --fix",
+    "lint": "eslint package.json tsconfig.json src test samples --ext .ts -f html -o core-amqp-lintReport.html || exit 0",
     "pack": "npm pack 2>&1",
     "prebuild": "npm run clean",
     "test:browser": "npm run build:test && npm run unit-test:browser && npm run integration-test:browser",
@@ -73,6 +73,7 @@
     "rhea-promise": "^1.0.0"
   },
   "devDependencies": {
+    "@azure/eslint-plugin-azure-sdk": "^2.0.1",
     "@azure/identity": "1.0.0-preview.3",
     "@types/chai": "^4.1.6",
     "@types/chai-as-promised": "^7.1.0",

diff --git a/sdk/core/core-auth/.eslintrc.json b/sdk/core/core-auth/.eslintrc.json
@@ -0,0 +1,7 @@
+{
+  "plugins": ["@azure/azure-sdk"],
+  "extends": ["../../.eslintrc.json", "plugin:@azure/azure-sdk/recommended"],
+  "parserOptions": {
+    "createDefaultProgram": true
+  }
+}
diff --git a/sdk/core/core-auth/package.json b/sdk/core/core-auth/package.json
@@ -23,8 +23,8 @@
     "integration-test:browser": "echo skipped",
     "integration-test:node": "echo skipped",
     "integration-test": "npm run integration-test:node && npm run integration-test:browser",
-    "lint:fix": "eslint \"src/**/*.ts\" \"test/**/*.ts\" -c ../../.eslintrc.json --fix --fix-type [problem,suggestion]",
-    "lint": "eslint -c ../../.eslintrc.json src test --ext .ts -f html -o template-lintReport.html || exit 0",
+    "lint:fix": "eslint package.json tsconfig.json \"src/**/*.ts\" \"test/**/*.ts\" --fix --fix-type [problem,suggestion]",
+    "lint": "eslint package.json tsconfig.json src test --ext .ts -f html -o template-lintReport.html || exit 0",
     "pack": "npm pack 2>&1",
     "prebuild": "npm run clean",
     "test:browser": "npm run build:test && npm run unit-test:browser && npm run integration-test:browser",
@@ -61,6 +61,7 @@
     "tslib": "^1.9.3"
   },
   "devDependencies": {
+    "@azure/eslint-plugin-azure-sdk": "^2.0.1",
     "@microsoft/api-extractor": "^7.1.5",
     "@types/mocha": "^5.2.5",
     "@types/node": "^8.0.0",

diff --git a/sdk/core/core-http/.eslintrc.json b/sdk/core/core-http/.eslintrc.json
@@ -0,0 +1,7 @@
+{
+  "plugins": ["@azure/azure-sdk"],
+  "extends": ["../../.eslintrc.json", "plugin:@azure/azure-sdk/recommended"],
+  "parserOptions": {
+    "createDefaultProgram": true
+  }
+}
diff --git a/sdk/core/core-http/package.json b/sdk/core/core-http/package.json
@@ -73,8 +73,8 @@
     "integration-test:browser": "echo skipped",
     "integration-test:node": "echo skipped",
     "integration-test": "npm run integration-test:node && npm run integration-test:browser",
-    "lint:fix": "eslint \"lib/**/*.ts\" \"test/**/*.ts\" -c ../../.eslintrc.json --fix --fix-type [problem,suggestion]",
-    "lint": "eslint -c ../../.eslintrc.json lib test --ext .ts -f html -o core-http-lintReport.html || exit 0",
+    "lint:fix": "eslint package.json tsconfig.json \"lib/**/*.ts\" \"test/**/*.ts\" --fix --fix-type [problem,suggestion]",
+    "lint": "eslint package.json tsconfig.json lib test --ext .ts -f html -o core-http-lintReport.html || exit 0",
     "pack": "npm pack 2>&1",
     "prebuild": "npm run clean",
     "test:browser": "npm run build:test && npm run unit-test:browser && npm run integration-test:browser",
@@ -125,6 +125,7 @@
     "xml2js": "^0.4.19"
   },
   "devDependencies": {
+    "@azure/eslint-plugin-azure-sdk": "^2.0.1",
     "@azure/logger-js": "^1.0.2",
     "@types/chai": "^4.1.6",
     "@types/express": "^4.16.0",

diff --git a/sdk/core/core-tracing/.eslintrc.json b/sdk/core/core-tracing/.eslintrc.json
@@ -0,0 +1,7 @@
+{
+  "plugins": ["@azure/azure-sdk"],
+  "extends": ["../../.eslintrc.json", "plugin:@azure/azure-sdk/recommended"],
+  "parserOptions": {
+    "createDefaultProgram": true
+  }
+}
diff --git a/sdk/core/core-tracing/package.json b/sdk/core/core-tracing/package.json
@@ -23,8 +23,8 @@
     "integration-test:browser": "echo skipped",
     "integration-test:node": "echo skipped",
     "integration-test": "npm run integration-test:node && npm run integration-test:browser",
-    "lint:fix": "eslint \"src/**/*.ts\" \"test/**/*.ts\" -c ../../.eslintrc.json --fix --fix-type [problem,suggestion]",
-    "lint": "eslint -c ../../.eslintrc.json lib --ext .ts -f html -o template-lintReport.html || exit 0",
+    "lint:fix": "eslint package.json tsconfig.json \"src/**/*.ts\" \"test/**/*.ts\" --fix --fix-type [problem,suggestion]",
+    "lint": "eslint package.json tsconfig.json lib --ext .ts -f html -o template-lintReport.html || exit 0",
     "pack": "npm pack 2>&1",
     "prebuild": "npm run clean",
     "test:browser": "npm run build:test && npm run unit-test:browser && npm run integration-test:browser",
@@ -61,6 +61,7 @@
     "tslib": "^1.9.3"
   },
   "devDependencies": {
+    "@azure/eslint-plugin-azure-sdk": "^2.0.1",
     "@microsoft/api-extractor": "^7.1.5",
     "@types/mocha": "^5.2.5",
     "@types/node": "^8.0.0",

diff --git a/sdk/eventhub/event-hubs/.eslintrc.json b/sdk/eventhub/event-hubs/.eslintrc.json
@@ -0,0 +1,7 @@
+{
+  "plugins": ["@azure/azure-sdk"],
+  "extends": ["../../.eslintrc.json", "plugin:@azure/azure-sdk/recommended"],
+  "parserOptions": {
+    "createDefaultProgram": true
+  }
+}
diff --git a/sdk/eventhub/event-hubs/package.json b/sdk/eventhub/event-hubs/package.json
@@ -50,8 +50,8 @@
     "integration-test:browser": "echo skipped",
     "integration-test:node": "mocha -t 1200000 test-dist/index.js --reporter mocha-multi --reporter-options spec=-,mocha-junit-reporter=-",
     "integration-test": "npm run integration-test:node && npm run integration-test:browser",
-    "lint:fix": "eslint -c ../../.eslintrc.json src test samples --ext .ts --fix",
-    "lint": "eslint -c ../../.eslintrc.json src test samples --ext .ts -f html -o event-hubs-lintReport.html || exit 0",
+    "lint:fix": "eslint package.json tsconfig.json src test samples --ext .ts --fix",
+    "lint": "eslint package.json tsconfig.json src test samples --ext .ts -f html -o event-hubs-lintReport.html || exit 0",
     "pack": "npm pack 2>&1",
     "prebuild": "npm run clean",
     "test:browser": "npm run build:test && npm run unit-test:browser && npm run integration-test:browser",
@@ -76,6 +76,7 @@
     "uuid": "^3.3.2"
   },
   "devDependencies": {
+    "@azure/eslint-plugin-azure-sdk": "^2.0.1",
     "@azure/identity": "1.0.0-preview.3",
     "@microsoft/api-extractor": "^7.1.5",
     "@types/async-lock": "^1.1.0",

diff --git a/sdk/eventhub/event-processor-host/.eslintrc.json b/sdk/eventhub/event-processor-host/.eslintrc.json
@@ -0,0 +1,7 @@
+{
+  "plugins": ["@azure/azure-sdk"],
+  "extends": ["../../.eslintrc.json", "plugin:@azure/azure-sdk/recommended"],
+  "parserOptions": {
+    "createDefaultProgram": true
+  }
+}
diff --git a/sdk/eventhub/event-processor-host/package.json b/sdk/eventhub/event-processor-host/package.json
@@ -46,8 +46,8 @@
     "integration-test:browser": "echo skipped",
     "integration-test:node": "mocha -t 120000 test-dist/index.js --reporter mocha-multi --reporter-options spec=-,mocha-junit-reporter=-",
     "integration-test": "npm run integration-test:node && npm run integration-test:browser",
-    "lint:fix": "eslint -c ../../.eslintrc.json src test samples --ext .ts --fix",
-    "lint": "eslint -c ../../.eslintrc.json src test samples --ext .ts -f html -o event-processor-host-lintReport.html || exit 0",
+    "lint:fix": "eslint package.json tsconfig.json src test samples --ext .ts --fix",
+    "lint": "eslint package.json tsconfig.json src test samples --ext .ts -f html -o event-processor-host-lintReport.html || exit 0",
     "pack": "npm pack 2>&1",
     "prebuild": "npm run clean",
     "test:browser": "npm run build:test && npm run unit-test:browser && npm run integration-test:browser",
@@ -68,6 +68,7 @@
     "uuid": "^3.3.2"
   },
   "devDependencies": {
+    "@azure/eslint-plugin-azure-sdk": "^2.0.1",
     "@microsoft/api-extractor": "^7.1.5",
     "@types/async-lock": "^1.1.0",
     "@types/chai": "^4.1.6",

diff --git a/sdk/keyvault/keyvault-certificates/.eslintrc.json b/sdk/keyvault/keyvault-certificates/.eslintrc.json
@@ -0,0 +1,7 @@
+{
+  "plugins": ["@azure/azure-sdk"],
+  "extends": ["../../.eslintrc.json", "plugin:@azure/azure-sdk/recommended"],
+  "parserOptions": {
+    "createDefaultProgram": true
+  }
+}