Skip to content

Commit

Permalink
Merge pull request kubernetes#16373 from rifelpet/skipregex
Browse files Browse the repository at this point in the history
Skip hostname test for all aws jobs by default
  • Loading branch information
k8s-ci-robot authored Feb 22, 2024
2 parents f21109e + fba4c1c commit 2900d27
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions tests/e2e/pkg/tester/skip_regex.go
Original file line number Diff line number Diff line change
Expand Up @@ -141,9 +141,9 @@ func (t *Tester) setSkipRegexFlag() error {
skipRegex += "|should.verify.that.all.nodes.have.volume.limits"
}

if k8sVersion.Minor < 28 && cluster.Spec.LegacyCloudProvider == "aws" {
if cluster.Spec.LegacyCloudProvider == "aws" {
// This test fails on RHEL-based distros because they return fully qualified hostnames yet the k8s node names are not fully qualified.
// Keeping this unskipped in k8s 1.28 so we can still get signal without causing all grid jobs to fail.
// Dedicated job testing this: https://testgrid.k8s.io/kops-misc#kops-aws-k28-hostname-bug123255
// ref: https://github.com/kubernetes/kops/issues/16349
// ref: https://github.com/kubernetes/kubernetes/issues/123255
skipRegex += "|Services.should.function.for.service.endpoints.using.hostNetwork"
Expand Down

0 comments on commit 2900d27

Please sign in to comment.