Introduce HTML viewer to display html file on azkaban #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,22 @@ | |||
| /* | |||
| * Copyright 2014 LinkedIn Corp. | |||
| @@ -0,0 +1,80 @@ | |||
| /* | |||
| * Copyright 2012 LinkedIn Corp. | |||
burgerkingeater
added a commit
that referenced
this pull request
Feb 27, 2018
This reverts commit 767973a.
|
@chengren311 in the future, please describe the reason for the revert in the commit message. Thanks |
|
@HappyRay sure, thanks for reminder. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently html files are treated as plain text on azkaban, for super simple html files, that works fine since they are still readable. For complicated and large html files, this will be unreadable. The new html viewer allows user to open up html files and view it like an actual html file. This viewer is used to display files with ".htm" or ".html" extension.