Add IS0-8601 and RFC-3339 pattern without microsecond fraction #505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 12923419355Details
💛 - Coveralls |
veewee
commented
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In both ISO-8601 and RFC-3339, the microseconds part (decimal fraction) is optional.
In this PR, I introduce 2 more options for these patterns without microseconds.
This makes it interopable with the default PHP date formats (atom, iso-8601 and expanded, DATE_RFC3339 and expanded)
The ISO standard goes even further and makes seconds optional, 2-year digits possible, ...
That is out of scope for now.