refactor: use list-of-strings style "selectors" #69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jack Cherng <jfcherng@gmail.com>
jfcherng
force-pushed
the
refactor/readable-selectors
branch
from
148077f to
54a6852
Compare
braver
suggested changes
Nov 1, 2020
braver
approved these changes
Nov 1, 2020
cristianl
reviewed
Nov 1, 2020
Comment on lines
+75
to
+79
| # old style discouraged single-string selector | ||
| selector = self.settings.get('selector') | ||
| if not selector: | ||
| # new style list of strings selectors | ||
| selector = "(" + ")|(".join(self.settings.get('selectors')) + ")" |
Collaborator
There was a problem hiding this comment.
Suggested change
| # old style discouraged single-string selector | |
| selector = self.settings.get('selector') | |
| if not selector: | |
| # new style list of strings selectors | |
| selector = "(" + ")|(".join(self.settings.get('selectors')) + ")" | |
| selector = "(" + ")|(".join(self.settings.get('selectors')) + ")" |
Since the single-string selector was only publicly available on 2.0.0, I think we can get away with skipping this check
Collaborator
|
Released in 2.1.0. Thanks for the PRs! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "selector" setting in v2 is a very long single-line string. That makes is unreadable and diff-unfriendly.
This PR proposes to make it into a list of selectors.