Fix idempotency when deleting CAPI clusters #992
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no need to run the deletion when the cluster does not exist.
MoteHue
force-pushed
the
fix-capi-cluster-destroy-idempotency
branch
from
7ce1337 to
eb43d19
Compare
sd109
requested changes
Oct 9, 2025
Contributor
sd109
left a comment
sd109
left a comment
There was a problem hiding this comment.
Thanks for the fix! A few minor comments from me.
JohnGarbutt
reviewed
Oct 13, 2025
Co-authored-by: Scott Davidson <49713135+sd109@users.noreply.github.com>
MoteHue
force-pushed
the
fix-capi-cluster-destroy-idempotency
branch
from
7d9c20c to
16bea45
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no need to run the deletion when the cluster does not exist.