Expo Config Plugin fix - use app.plugin.js to fix Typescript issues #126
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need to modify package.json files list so
"app.plugin.js",
gets shipped as part of the npm packageIf the plugin was written in typescript, it would need to be transpiled for Node prior to being used. For simplicity, rather than add ts-node as a dependency and build step, I've converted the TS plugin into JS so no transpiling is needed. This is what most of the Expo Config Plugin Examples do
I also added a
style
prop toUnityView
which fixes a typescript issueThis also fixes a Typescript regression that arose when we added
plugins
dir to the exported library:In v 1.0.10 you would need to
import UnityView from "@azesmway/react-native-unity/lib/typescript/src"
in order to properly import the UnityView types, since the typescript build containedsrc
andplugins
. Removing theplugins
tsconfig fixes this, so the contents ofsrc
are the only thing exported, and aimport UnityView from "@azesmway/react-native-unity
works as expected.