Handle Strong app verification process #10
Conversation
Handle strong auth verification on new Ip
|
| GitGuardian id | Secret | Commit | Filename | |
|---|---|---|---|---|
| 8566878 | Generic High Entropy Secret | 638d74b | src/bourso/client.rs | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
|
Still in draft, need to handle a last process. @azerpas |
|
|
||
| self.client | ||
| .request(Method::OPTIONS, format!( | ||
| "https://api.boursobank.com/services/api/v1.7/_user_/_{}_/session/challenge/checkwebtoapp/10305", |
|
|
||
|
|
||
| let strong_auth_url = format!( | ||
| "https://api.boursobank.com/services/api/v1.7/_user_/_{}_/session/challenge/startwebtoapp/10305", |
| log_with_timestamp(format!("Strong authentication: Sending request to app").blue()); | ||
|
|
||
| // Await for user to press enter | ||
| log_with_timestamp(format!("Click 'Enter' after the app verification is complete.").yellow()); |
There was a problem hiding this comment.
long lines should be splited like this
log_with_timestamp(
format!(
"Click 'Enter' after the app verification is complete."
).yellow()
);
What do you think @Tixwell ?
There was a problem hiding this comment.
This should be formatter's function. Do you want me to add rustfmt.toml and a GA to check it?
There was a problem hiding this comment.
@valeratrades sure, that would be helpful!
3 participants
No description provided.