Skip to content

Improve the codebase#36

Merged
wizzymore merged 5 commits intomasterfrom
new-version
Jan 26, 2026
Merged

Improve the codebase#36
wizzymore merged 5 commits intomasterfrom
new-version

Conversation

@wizzymore
Copy link
Member

Changes Proposed:

  • Improve the codebase
  • Standardise the names used for the module
  • Improve configuration names

This introduces braking changes, people will need to copy the new config to their configs/modules folder
@Helias
Copy link
Member

Helias commented Jan 25, 2026

build is failing

[ 18%] Building CXX object src/server/scripts/CMakeFiles/scripts.dir/Commands/cs_account.cpp.o
../../modules/mod-world-chat/src/WorldChat.cpp:21:19: fatal error: static declaration of 'g_wcConfig' follows non-static declaration
   21 |     static Config g_wcConfig{};
      |                   ^
../../modules/mod-world-chat/src/WorldChat.h:84:19: note: previous declaration is here
   84 |     extern Config g_wcConfig;
      |                   ^
1 error generated.
gmake[2]: *** [modules/CMakeFiles/modules.dir/build.make:93: modules/CMakeFiles/modules.dir/mod-world-chat/src/WorldChat.cpp.o] Error 1
gmake[1]: *** [CMakeFiles/Makefile2:1473: modules/CMakeFiles/modules.dir/all] Error 2
gmake[1]: *** Waiting for unfinished jobs....

@wizzymore
Copy link
Member Author

Hi Stefano, thanks for the hint. MSVC being a permissive mf once again! :))
Let's hope this fixes it as i don't have a linux machine set-up right now and i am too lazy to build on my mac with clang.

Fix formatting, remove unused function
@wizzymore wizzymore merged commit 26295fe into master Jan 26, 2026
1 check passed
@wizzymore wizzymore deleted the new-version branch January 26, 2026 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants