(feature) allow config to be reloaded without server restart. #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Helias
reviewed
May 12, 2023
src/Solocraft.cpp
Outdated
| SetInitialWorldSettings(); | ||
| } | ||
| // Squelch compile warning | ||
| (void) reload; |
There was a problem hiding this comment.
could you explain to me exactly what this line of code does?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the
OnBeforeConfigLoadfunction to reload settings from the configuration file on a.reload configcommand from the server.Not sure why this was explicitly disabled, but I've seen no ill effects on my up-to-date Azerothcore server. Really facilitates testing without constant server restarts.
I did verify that even if you update the difficult value for an instance you're currently in, you still get the correct amount of buff reversed when you exit the instance (since its using the data in the DB to track what you were buffed with).