feat(CORE): XP Balancing and Minor Fix #29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New Feature: XP Balancing Fix: Closes Issue azerothcore#24
…into XP-Feature
acidmanifesto
approved these changes
Feb 26, 2022
|
Is this ready for merge? |
|
As far as I am concerned, yes. Also can someone look at the SoloLFG module I have had a PR there for a long time that removes the need for the patch and it has been approved but hasn't been merged and with no reason why. |
Give me a bit. Thank you for the pr. We dont really get notifications about the modules on git for some reason so thank you for bringing that to my attention. Thank you for the pr. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Feature: XP Balancing:
Solocraft now has the ability to rein in experience gained to keep from over leveling your character by just going through one instance. This rapid leveling is due to WOW giving your character all the shared XP from the instance that is supposed to be given to everyone in the group.
The Feature has two options: Disable/Enable XP Gain and Disable/Enable XP Balancing. The balancing will take into account how many are in your group and balance it so your character only receives the amount you would get if you had the max amount of players in your group.
Fix: Closes Issue #24
Was able to add giving a player's Pet max health upon entering the instance.
TODO:
Pet Mana. The normal methods of giving the max Mana to pets doesn't seem to work upon entering an instance. Will still look for a working fix.