Logging out while in a dungeon and logging back in does not rebuff the character

[LannyE]

While using Solocraft I noticed that if for some reason I logout while being in a dungeon/instance and then relog back in I do not get the buff from this module. To add insult to injury if I leave the instance my character gets debuffed again.

Looking at the code and doing some minor testing it appears it debuffs your character on login and then turns around and tries to add the buff to your character. I assume this is because of mapchange being called a few times on login.

I noticed it runs through this code both times:

            // Adjust player stats
            _unitDifficulty[player->GetGUID()] = difficulty;
            for (int32 i = STAT_STRENGTH; i < MAX_STATS; ++i)
            {
                // Buff the player
                player->HandleStatModifier(UnitMods(UNIT_MOD_STAT_START + i), TOTAL_PCT, float(difficulty * 100), true);
            }

            // Set player health
            player->SetFullHealth();
            if (player->getPowerType() == POWER_MANA)
            {
                // Buff the player's health
                player->SetPower(POWER_MANA, player->GetMaxPower(POWER_MANA));
            }

The first time it passes through the difficulty is 1. The second time it uses the set dungeon difficulty but it fails to apply the buff. I think it works only on a mapchange because the character goes through some sort of refresh. The HandleStatModifier and the SetFullHealth methods don't seem to do the refresh alone. I have been trying to fix this but can't find any documentation or any examples in the Azerothcore source code that has worked so far.

I have tried these methods with little (saw some stats refresh but not mana or hp changes) or no changes:
ApplyStatPercentBuffMod
UpdateAllStats
UpdateMaxHealth

If anyone who reads this has any clues or comments I would appreciate it.

[LannyE]

I solved this issue:

void ApplyBuffs(Player* player, Map* map, int difficulty, int /*numInGroup*/)
{

    if (difficulty > 1)
    {

        // InstanceMap *instanceMap = map->ToInstanceMap();
        // InstanceScript *instanceScript = instanceMap->GetInstanceScript();
        // Announce to player
        std::ostringstream ss;
        ss << "|cffFF0000[SoloCraft] |cffFF8000" << player->GetName() << " entered %s  - Difficulty Offset: %d.";
        ChatHandler(player->GetSession()).PSendSysMessage(ss.str().c_str(), map->GetMapName(), difficulty);

        // Adjust player stats
        _unitDifficulty[player->GetGUID()] = difficulty;
        for (int32 i = STAT_STRENGTH; i < MAX_STATS; ++i)
        {
            // Buff the player
            player->HandleStatModifier(UnitMods(UNIT_MOD_STAT_START + i), TOTAL_PCT, float(difficulty * 100), true);
        }

        // Set player health
        player->SetFullHealth();
        if (player->getPowerType() == POWER_MANA)
        {
            // Buff the player's health
            player->SetPower(POWER_MANA, player->GetMaxPower(POWER_MANA));
        }
    }
   else
         ClearBuffs(player, map);
}

[Helias]

Please open a PR to solve the problem.
Moreover, we do not close the issue if the problem has not been solved in the master repository.

Thank you for your fix, but please open a PR

[LannyE]

Actually I was working on that. Never done it before. I completely revamped this module with many new features and fixes so I was making a PR for it. Do you want me to do a PR only for this fix alone or just state it is in the new update I am proposing?

[Helias]

if you can, you could open 2 PRs one with the fix and the other one with the features that you added locally.

It would be really great 🚀