fix(DB/skinning): add missing skinning loot 1/4 #20643
Open
+75
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I extracted some missing loots from wowhead using this tool https://github.com/Helias/wowhead-scraper
I will push soon more fixes, this is the part 1/4 of the skinning ones.
Changes Proposed:
add the skinning loot of the following NPCs
883, 890, 3532, 2098, 2620, 1894, 1933, 4166, 1388, 1756SOURCE:
WoWhead uses the "wowhead client" to sniff the data from the retail and it does some statistics, it should be accurate enough as the sniffs usually are.
https://www.wowhead.com/wotlk/npc=883
https://www.wowhead.com/wotlk/npc=890
https://www.wowhead.com/wotlk/npc=3532
https://www.wowhead.com/wotlk/npc=2098
https://www.wowhead.com/wotlk/npc=2620
https://www.wowhead.com/wotlk/npc=1894
https://www.wowhead.com/wotlk/npc=1933
https://www.wowhead.com/wotlk/npc=4166
https://www.wowhead.com/wotlk/npc=1388
https://www.wowhead.com/wotlk/npc=1756
How to Test AzerothCore PRs
When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].
You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:
http://www.azerothcore.org/wiki/How-to-test-a-PR
REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).
For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.