Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gameobject/Wrong Banners): Wrong faction banners while event 20 running. #20539

Merged
merged 3 commits into from
Nov 13, 2024

Conversation

TheSCREWEDSoftware
Copy link
Contributor

Changes Proposed:

  • Core (units, players, creatures, game systems).
  • Scripts (bosses, spell scripts, creature scripts).
  • Database (SAI, creatures, etc).

Issues Addressed:

SOURCE:

The changes have been validated through:

  • Live research (checked on live servers, e.g Classic WotLK, Retail, etc.)
  • Sniffs (remember to share them with the open source community!)
  • Video evidence, knowledge databases or other public sources (e.g forums, Wowhead, etc.)
  • The changes promoted by this pull request come partially or entirely from another project (cherry-pick). Cherry-picks must be committed using the proper --author tag in order to be accepted, thus crediting the original authors, unless otherwise unable to be found

Tests Performed:

This PR has been:

  • Tested in-game by the author.
  • Tested in-game by other community members/someone else other than the author/has been live on production servers.
  • This pull request requires further testing and may have edge cases to be tested.

How to Test the Changes:

  • This pull request can be tested by following the reproduction steps provided in the linked issue
  • This pull request requires further testing. Provide steps to test your changes. If it requires any specific setup e.g multiple players please specify it as well.

chromiecraft/chromiecraft#7088 (comment)

@github-actions github-actions bot added the DB related to the SQL database label Nov 12, 2024
Co-authored-by: Benjamin Jackson <38561765+heyitsbench@users.noreply.github.com>
@sudlud sudlud merged commit d78350b into azerothcore:master Nov 13, 2024
17 checks passed
jorge990125 pushed a commit to jorge990125/azerothcore-wotlk that referenced this pull request Nov 14, 2024
…erothcore#20539)

* Created SQL

* Banners corrected

* Updated to match Bench's suggestion

Co-authored-by: Benjamin Jackson <38561765+heyitsbench@users.noreply.github.com>

---------

Co-authored-by: Benjamin Jackson <38561765+heyitsbench@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DB related to the SQL database To Be Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants