Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document cairo dependencies #7

Merged
merged 2 commits into from
Nov 27, 2020
Merged

Document cairo dependencies #7

merged 2 commits into from
Nov 27, 2020

Conversation

icio
Copy link
Contributor

@icio icio commented Nov 27, 2020

I'm not sure whether both libjpeg-dev libgif-dev are required but the stack overflow post I copied it from had those with cairo, so they're there. libgirepository1.0-dev was requested by one of the python dependencies when I tried to pipx install camset.

Nice project, thanks :)

@azeam
Copy link
Owner

azeam commented Nov 27, 2020

Thanks for the PR! Never noticed this but it's likely that I've installed some non-default packages (GTK3 dev stuff? At least libcairo comes with libgtk-3-dev, which I had installed), which appear to be necessary for pip to install the dependencies.

Anyway, I've tried to clean up my environment from related packages and pip caches and as far as I can tell only libcairo2-dev and libgirepository1.0-dev are necessary, I think you can remove the other two and I will merge the PR.

@icio
Copy link
Contributor Author

icio commented Nov 27, 2020

Done 👍

@azeam azeam merged commit 5770f93 into azeam:master Nov 27, 2020
@azeam
Copy link
Owner

azeam commented Nov 27, 2020

Perfect, thanks for that!

@icio icio deleted the patch-1 branch November 27, 2020 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants