merge main #2202
mat-1Annotations
12 warnings
|
the following explicit lifetimes could be elided: 'a:
azalea-protocol/src/packets/game/c_player_chat.rs#L124
warning: the following explicit lifetimes could be elided: 'a
--> azalea-protocol/src/packets/game/c_player_chat.rs:124:28
|
124 | pub fn translation_key<'a>(&'a self) -> &'a str {
| ^^ ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
= note: `#[warn(clippy::needless_lifetimes)]` on by default
help: elide the lifetimes
|
124 - pub fn translation_key<'a>(&'a self) -> &'a str {
124 + pub fn translation_key(&self) -> &str {
|
|
|
casting to the same type is unnecessary (`u64` -> `u64`):
azalea-world/src/chunk_storage.rs#L346
warning: casting to the same type is unnecessary (`u64` -> `u64`)
--> azalea-world/src/chunk_storage.rs:346:56
|
346 | let data: Box<[u64]> = data.iter().map(|x| *x as u64).collect();
| ^^^^^^^^^ help: try: `{ *x }`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
= note: `#[warn(clippy::unnecessary_cast)]` on by default
|
|
use `std::ptr::eq` when comparing raw pointers:
azalea-brigadier/src/command_dispatcher.rs#L430
warning: use `std::ptr::eq` when comparing raw pointers
--> azalea-brigadier/src/command_dispatcher.rs:430:31
|
430 | let redirect = if redirect.data_ptr() == self.root.data_ptr() {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `std::ptr::eq(redirect.data_ptr(), self.root.data_ptr())`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_eq
|
|
use `std::ptr::eq` when comparing raw pointers:
azalea-brigadier/src/command_dispatcher.rs#L352
warning: use `std::ptr::eq` when comparing raw pointers
--> azalea-brigadier/src/command_dispatcher.rs:352:35
|
352 | let redirect = if redirect.data_ptr() == self.root.data_ptr() {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `std::ptr::eq(redirect.data_ptr(), self.root.data_ptr())`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_eq
= note: `#[warn(clippy::ptr_eq)]` on by default
|
|
the following explicit lifetimes could be elided: 'a:
azalea-protocol/src/packets/game/c_player_chat.rs#L124
warning: the following explicit lifetimes could be elided: 'a
--> azalea-protocol/src/packets/game/c_player_chat.rs:124:28
|
124 | pub fn translation_key<'a>(&'a self) -> &'a str {
| ^^ ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
= note: `#[warn(clippy::needless_lifetimes)]` on by default
help: elide the lifetimes
|
124 - pub fn translation_key<'a>(&'a self) -> &'a str {
124 + pub fn translation_key(&self) -> &str {
|
|
|
casting to the same type is unnecessary (`u64` -> `u64`):
azalea-world/src/chunk_storage.rs#L346
warning: casting to the same type is unnecessary (`u64` -> `u64`)
--> azalea-world/src/chunk_storage.rs:346:56
|
346 | let data: Box<[u64]> = data.iter().map(|x| *x as u64).collect();
| ^^^^^^^^^ help: try: `{ *x }`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
= note: `#[warn(clippy::unnecessary_cast)]` on by default
|
|
use `std::ptr::eq` when comparing raw pointers:
azalea-brigadier/src/command_dispatcher.rs#L430
warning: use `std::ptr::eq` when comparing raw pointers
--> azalea-brigadier/src/command_dispatcher.rs:430:31
|
430 | let redirect = if redirect.data_ptr() == self.root.data_ptr() {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `std::ptr::eq(redirect.data_ptr(), self.root.data_ptr())`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_eq
|
|
use `std::ptr::eq` when comparing raw pointers:
azalea-brigadier/src/command_dispatcher.rs#L352
warning: use `std::ptr::eq` when comparing raw pointers
--> azalea-brigadier/src/command_dispatcher.rs:352:35
|
352 | let redirect = if redirect.data_ptr() == self.root.data_ptr() {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `std::ptr::eq(redirect.data_ptr(), self.root.data_ptr())`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_eq
= note: `#[warn(clippy::ptr_eq)]` on by default
|
|
clippy_check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
clippy_check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
clippy_check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
clippy_check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|