Create on metric description per cloudwatch stat #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently when fetching resources an empty array for the current list of resources is initialized and is saved in place of the existing list. If this list is accessed by one of the metrics go routines before it has been fully populated then that metric will not be populated for the missing resources. This diff adds locking and changes the new array to only be saved once fully populated to prevent such data races from occurring.
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
| ) | ||
|
|
||
| type configMetric struct { | ||
| type ConfigMetric struct { |
There was a problem hiding this comment.
exported type ConfigMetric should have comment or be unexported
| ) | ||
|
|
||
| type configMetric struct { | ||
| type ConfigMetric struct { |
There was a problem hiding this comment.
exported type ConfigMetric should have comment or be unexported
| ) | ||
|
|
||
| type configMetric struct { | ||
| type ConfigMetric struct { |
There was a problem hiding this comment.
exported type ConfigMetric should have comment or be unexported
aywrite
force-pushed
the
master
branch
2 times, most recently
from
9f51c3a to
ab1963b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.