docs: Go Docker セクションを serve サブコマンドに合わせて更新 - #334
Merged
Conversation
- CLI モード: --model/--text/--output → -m/-t/-f (実際のフラグに修正) - サーバーモード: --server --host --port → serve --addr (serve サブコマンドに修正) - エンドポイントのテスト例を追加 - OpenJTalk/ORT 1.24.4 の説明を追加
There was a problem hiding this comment.
Pull request overview
docker/README.md の Go 向け Docker イメージの利用手順を、Go 実装側（serve サブコマンド追加・CLI フラグ体系）と整合するように更新する PR です。Go Docker イメージの説明を最新の依存関係（OpenJTalk 日本語G2P / ONNX Runtime）込みで明確化し、HTTP エンドポイントの簡易テスト手順も追加しています。
Changes:
- Go セクションの CLI 実行例を
-m/-t/-fフラグに更新 - HTTP サーバーモードを
serve --addr :8080形式に更新 - OpenJTalk 日本語G2P + ONNX Runtime v1.24.4 の言及と、curl による疎通例を追加
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
docker/README.mdの Go セクションが実装と不一致だったため修正serveサブコマンドと正しいCLIフラグに更新変更点
--model,--text,--output-m,-t,-f--server --host 0.0.0.0 --port 8080serve --addr :8080Test plan