Skip to content

Conversation

@SamrendraS
Copy link

Motivation and Resolution

This PR extends the bot's domain resolution capabilities to support .brother domains alongside the existing .stark domains. The changes allow the bot to recognize and resolve .brother domains in tweets, making it more comprehensive in handling Starknet identity systems.

Usage related changes

  • Added support for resolving .brother domain names in tweets
  • Implemented contract interaction with Brother ID for domain resolution
  • Updated domain detection regex to include .brother TLD
  • Added utility function for encoding domain parts according to Brother ID specifications

Development related changes

  • Added BROTHER_CONTRACT environment variable requirement
  • Enhanced error logging for domain resolution failures
  • Maintained consistent error handling with existing .stark resolution
  • Added domain encoding helper function useEncoded for Brother ID format

Checklist:

  • Performed a self-review of the code
  • Implemented proper error handling
  • Maintained backward compatibility with existing .stark resolution
  • Added necessary environment variable documentation
  • Updated tests (needs to be done)
  • Verified domain resolution works for both .stark and .brother domains

Note: The implementation follows the same pattern as the existing .stark resolution while adding the necessary contract interactions for .brother domains. Environment variable documentation needs to be updated to include the new BROTHER_CONTRACT requirement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant