Power controls tweaks and fixes #29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayufan
requested changes
Dec 19, 2022
ayufan
requested changes
Dec 19, 2022
ayufan
requested changes
Dec 19, 2022
ayufan
requested changes
Dec 19, 2022
|
Just this snippet in here without instance variable.
…On Mon, 19 Dec 2022 at 20:33, maniman303 ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In PowerControl/Controller.cs
<#29 (comment)>
:
> @@ -50,6 +55,21 @@ public Controller()
if (Instance.WantsRunOnStartup)
startupManager.Startup = true;
+ DeviceManager.LoadDisplays();
+ contextTimer = new System.Windows.Forms.Timer();
Isolate by moving it to other class or to other method? Yeah, it clicks on
first tick :)
—
Reply to this email directly, view it on GitHub
<#29 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AASOSQKSJ7DRVIDOJRVCHVLWOC2BHANCNFSM6AAAAAATCFKR7I>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
ayufan
pushed a commit
that referenced
this pull request
Dec 20, 2022
* Fix context menu, add osd toggle * Update values on number of displays change * Check display info in DeviceManager * Refactor OSD toggle * Isolate display context setup * Move more context stuff to the display initialize method
ayufan
pushed a commit
that referenced
this pull request
Dec 20, 2022
* Fix context menu, add osd toggle * Update values on number of displays change * Check display info in DeviceManager * Refactor OSD toggle * Isolate display context setup * Move more context stuff to the display initialize method
ayufan
pushed a commit
that referenced
this pull request
Jan 3, 2023
* Fix context menu, add osd toggle * Update values on number of displays change * Check display info in DeviceManager * Refactor OSD toggle * Isolate display context setup * Move more context stuff to the display initialize method
ayufan
pushed a commit
that referenced
this pull request
Jan 5, 2023
* Fix context menu, add osd toggle * Update values on number of displays change * Check display info in DeviceManager * Refactor OSD toggle * Isolate display context setup * Move more context stuff to the display initialize method
ayufan
pushed a commit
that referenced
this pull request
Jan 5, 2023
* Fix context menu, add osd toggle * Update values on number of displays change * Check display info in DeviceManager * Refactor OSD toggle * Isolate display context setup * Move more context stuff to the display initialize method
ayufan
pushed a commit
that referenced
this pull request
Jan 9, 2023
* Fix context menu, add osd toggle * Update values on number of displays change * Check display info in DeviceManager * Refactor OSD toggle * Isolate display context setup * Move more context stuff to the display initialize method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I have fixed the placement of context menu on first right click, added a OSD toggle shortcut and fixed wrong values in OSD / context menu after number of displays changes.
The multi display support is not prettiest, but seams to be reliable and will be a huge plus for game profiles rewrite.