Skip to content

Commit

Permalink
Fix the CI [changelog skip] (puma#2214)
Browse files Browse the repository at this point in the history
* Skip TestThreadPool#test_trim_leaves_min on JRuby

* It fails frequently there too.

* Use Bundler 1 in CI

* Using Bundler 2 seems to cause several failures:
  https://github.com/puma/puma/runs/553627446
  • Loading branch information
eregon authored Apr 2, 2020
1 parent a6dcb50 commit b1c27ee
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions .github/workflows/ruby.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ jobs:
uses: MSP-Greg/setup-ruby-pkgs@v1
with:
ruby-version: ${{ matrix.ruby }}
bundler: 1
apt-get: ragel
brew: ragel

Expand Down
2 changes: 1 addition & 1 deletion test/test_thread_pool.rb
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ def test_trim
end

def test_trim_leaves_min
skip_on :truffleruby # Undiagnose thread race. TODO fix
skip_on :jruby, :truffleruby # Undiagnose thread race. TODO fix
pool = new_pool(1, 2) do |work|
@work_mutex.synchronize do
@work_done.signal
Expand Down

0 comments on commit b1c27ee

Please sign in to comment.