fix multiple tasks coexists at same time when rescheduled.

[pxp9]

I have been working with fang and I have noticed that it is a small period of time that two exactly equal tasks can live at the same time,

In order to fix this i have just reorder the code to

First execute task

then reschedule the task.

This way when a task is runned and the RetentionMode is set to remove it when it is finished, the task will be removed before it is reschedule the new task.

[Dopplerian]

Is there a way of writing a test to detect this? It would be good to prevent it from being reintroduced in the future.

[pxp9]

I think there is no way to test this because it is done atomically.

Maybe it one way to do it but i am not sure.

It can be done a method that will request the number of tasks between the task is executing and it is scheduled.

Let me try it.

[pxp9]

Is there a way of writing a test to detect this? It would be good to prevent it from being reintroduced in the future.

no schedule until run test

this async test wont work will be stuck to infinite if the beahviour is changed.

[pxp9]

Is there a way of writing a test to detect this? It would be good to prevent it from being reintroduced in the future.

no schedule until run test

this async test wont work will be stuck to infinite if the beahviour is changed.

i dont know how to set a timeout

[pxp9]

Is there a way of writing a test to detect this? It would be good to prevent it from being reintroduced in the future.

no schedule until run test
this async test wont work will be stuck to infinite if the beahviour is changed.

i dont know how to set a timeout

this test does not seem to be consistant, the only way is consistant is that it will be stuck if the task is scheduled before runned.

Ignored tests seem to not be working right now.

[Dopplerian]

The blocking::worker::worker_tests::executes_task_only_of_specific_type seems to be failing under specific circumstances on my machine. I'd be thankful if someone confirmed they had the same problem. The commands I run are the following:

make db
make diesel
git restore fang/src/blocking/schema.rs
make tests
make ignored

The test seems to only fail if both git restore and make tests are run.

I use git restore because make diesel adds a #[max_length = 64] line in fang/src/blocking/schema.rs right above uniq_hash -> Nullable<Bpchar>,.

[pxp9]

yeap make diesel is broken in this branch but in master is fine.

change task type of test

this commit should fix your issue when running ignored tests.

[Dopplerian]

LGTM