Repository navigation
search: recover empty versioned queries with one known prompt symbol - #139
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Comment |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughWhen an ChangesSymbol search fallback
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Feature Merge Risk: ⚪ Minimal · up to The fallback has no identified merge-blocking issue; it is ready for normal merge checks. Security Architecture ReviewSecurity architecture risk: 🔵 Low · up to The recovery path is narrowly gated and preserves requested-version filtering and result limits. No introduced security issue was identified. Assurance remains limited by incomplete security coverage and pending independent validation. Retained concerns Security review detailsSecurity Blast Radius
Trust Boundaries and Controls
Resilience and Maintainability Implications
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Vision — automated project maintainer Independent verification (temporary credential): success Head: {
"head_sha": "84277aea0168d4fdf721b20cfb8cde807b1c9256",
"base_sha": "b3e4c9ff143aa3c1b729552a6e7fce5118f62fbc",
"approved": true,
"summary": "Independent review found a product-relevant, version-scoped fallback with no dependency, schema, workflow, corpus, baseline, or tool-contract changes. On a freshly built 1,603-document index from pinned CPython 3.11.15, 3.12.13, and 3.13.13 sources, the frozen 65-case evaluation improved from 8 to 34 hits (+26), retained all 69 citations, changed no previously nonempty results, and passed the latency and budget gates. The owner's evidence named a different head and was not used as acceptance evidence. Hosted CI for this exact head has no checks yet and remains pending for publication and merge.",
"commands": [
{
"command": "git clone --no-checkout --depth=1 https://github.com/ayhammouda/python-docs-mcp-server.git repo",
"exit_code": 0
},
{
"command": "git fetch --depth=1 origin 84277aea0168d4fdf721b20cfb8cde807b1c9256 b3e4c9ff143aa3c1b729552a6e7fce5118f62fbc",
"exit_code": 0
},
{
"command": "/usr/local/bin/uv sync --locked --dev",
"exit_code": 0
},
{
"command": "/usr/local/bin/uv run --locked ruff check src/ tests/ benchmarks/ ops/ .github/scripts/",
"exit_code": 0
},
{
"command": "/usr/local/bin/uv run --locked pyright src/ benchmarks/",
"exit_code": 0
},
{
"command": "/usr/local/bin/uv run --locked pytest --tb=short -q",
"exit_code": 0
},
{
"command": "/usr/local/bin/uv run --locked python -m benchmarks validate-corpus --corpus docs/benchmarks/corpus.yml --schema docs/benchmarks/corpus.schema.json",
"exit_code": 0
},
{
"command": "/usr/local/bin/uv run --locked python-docs-mcp-server build-index --versions 3.11,3.12,3.13",
"exit_code": 0
},
{
"command": "/usr/local/bin/uv run --locked python-docs-mcp-server doctor",
"exit_code": 0
},
{
"command": "/usr/local/bin/uv run --locked python -m benchmarks.regression --output /tmp/pd-regression.json",
"exit_code": 0
},
{
"command": "PYTHONPATH=. /usr/local/bin/uv run --locked python /tmp/pd-verify-corpus.py",
"exit_code": 0
},
{
"command": "/usr/local/bin/uv build",
"exit_code": 0
},
{
"command": "git diff --check b3e4c9ff143aa3c1b729552a6e7fce5118f62fbc 84277aea0168d4fdf721b20cfb8cde807b1c9256",
"exit_code": 0
},
{
"command": "git rev-parse HEAD",
"exit_code": 0
}
],
"blockers": []
} |
|
Vision — automated project maintainer Merge decision for exact head
Proceeding only through |
1 participant
Refs #63.
User problem and scope
Natural-language questions naming one indexed stdlib symbol can return no results despite canonical documentation being available offline. Original lookup/FTS behavior runs first; only empty explicit-version auto searches may use exactly one distinct known prompt symbol. Multiple known symbols stay ambiguous. Existing kinds, no-version/nonempty behavior and result budgets remain unchanged. No corpus-aware routing, schema, dependency, ingestion or tool-contract changes.
Acceptance evidence
pdctl verifysucceeded: independent verdict. Fresh pinned CPython 3.11.15/3.12.13/3.13.13 complete-index evaluation independently reproduced 8 → 34 hits (+26), all 69 citations, unchanged previously nonempty results, passing latency/budget gates.The 8-to-34 measurements above are developer evidence on the retained historical patch-release index, with incomplete historical build provenance; they are not generated-answer accuracy, competitive or general latency claims. See #63 for the recorded decision and limitations.
Why this approach / owner review
Measured misses were predominantly candidate-generation failures. A narrow empty-result fallback preserves successful existing search behavior and explicitly notes which prompt symbol supplied the results. Vision owner static review found no blocking issues. No forbidden-territory expansion or existing-test weakening. CodeRabbit completed with no actionable findings; it does not replace independent verification.
Outcome review
Review on 2026-10-17. Rework/remove if independent source-pinned reproduction fails, hits/citations or version isolation regress, or user feedback shows misleading fallback results. Merged through SHA-matched
pdctl mergeon 2026-10-05 as10740c7d259ae8e7aa4fd8d9346f5cf3aa7acb5b; all five main workflows passed (CI, Product quality, Security Audit, CodeQL, Scorecard). Not released.Summary by CodeRabbit